402113 - Leopard is detected as OS 9 and downloads are not offered

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Wil Clouser [:clouserw]]

Got a report via email that a visitor with Leopard and Safari going to:

http://en.www.mozilla.com/en/firefox/

was told that Mac OS 9 was not supported and was not offered a download.  Our script is looking for "Mac OS X" in the user agent to determine which download to give.  Apparently leopard isn't sending that anymore.

As soon as I figure out what it is sending, I'll have a patch for review.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I just went to that site with Safari on Leopard (using the retail version) and was offered Firefox. Soooo ... WFM.

Comment 2

[Wil Clouser [:clouserw]]

I don't have leopard - anyone else confirm one way or the other?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

WFM, Leopard final release...

Comment 4

[Colin Barrett [:cbarrett]]

Maybe they were using an extension for Safari that either hides or obscures Safari's user agent.

Comment 5

[Wil Clouser [:clouserw]]

I just reread their report - they say it's working in Safari but not Opera.

Comment 6

[Colin Barrett [:cbarrett]]

WFM with whatever version of Opera is on the front page (9.24?)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

http://img117.imageshack.us/my.php?image=picture1mn5.png

screenshot of Opera 9.24 bringing up the 2.0.0.9 download from Mozilla.com, using OS X 10.5; verified WFM

Comment 8

[Jef E]

Hi,
A few notes:

First, sorry that I didn't include more info in the email, but I'm not used to having webmasters be responsive when I report an issue - they usually ignore them, so I guess I've gotten lazy in doing too much bug chasing. So, that being said, thanks to all of you for being so responsive :)


The problem appears to be when the Browser identity is set to IE.

Here are screenshots of page, and also "about" information on the 2 builds I used - 9.24 and 9.50b:

http://www-personal.umd.umich.edu/~jpelliot/images/9.24-pic1.png
http://www-personal.umd.umich.edu/~jpelliot/images/9.24-pic2.png
http://www-personal.umd.umich.edu/~jpelliot/images/9.5-pic1.png
http://www-personal.umd.umich.edu/~jpelliot/images/9.5-pic2.png

This is the user agent info passed when identifying as IE:
"Mozilla/4.0 (compatible; MSIE 6.0; Mac_PowerPC; en) Opera 9.50"
"Mozilla/4.0 (compatible; MSIE 6.0; Mac_PowerPC; en) Opera 9.24"

(Just a note, it appears that even the universal buils still currently report as PPC.)

Cheers

Comment 9

[Wil Clouser [:clouserw]]

The logic for that error message is:  

userAgent does not contain "Mac OS X" and does contain "Mac"

We could add a special check for Opera and offer the OS X download, but we could potentially get false positives if someone is running opera on OS 9 or before.  (Although the current version looks like it's only offered for OS X)

Any thoughts?

Comment 10

[Colin Barrett [:cbarrett]]

Opera is emulating the old Mac IE User Agent, it looks like. Find out what the last version of Opera offered for OS 9 was and if they're using something newer than that they have to be on OS X?

Though I think someone still using OS 9 must be on the look out for OS X stuff, and on the getfirefox.com page it says "Firefox 2.0.0.9 for Mac OS X". So, I don't think it's going to be too big of a problem.

Comment 11

[Wil Clouser [:clouserw]]

Attachment: ugly special case

From the Opera changelogs, it looks like Opera 7.5 beta 1 was the first release to require OS X, and I also stumbled across http://www.opera.com/support/search/view/570/ which lists the user agents for Opera 6 and 7 when spoofing.

I'd like to keep these tiny special cases out of the code, but I'd also like to get firefox to anyone who wants it, so I'm adding a patch.  I like the fallback code on mozilla-europe.org better - if it can't determine the OS or it's before OS X, it just shows links for Windows, Linux, and OS X and lets the user decide.

That's a substantial change to this code though and I don't think the time tradeoff is worth it.

Comment 12

[Reed Loden [:reed]]

Comment on attachment 288336 [details] [diff] [review]
ugly special case

I'd almost rather write it this way (fix indentation as required):

} else if (navigator.platform.indexOf("Mac") != -1) {
   gPlatform = PLATFORM_MAC;
   gCssClass = 'os_osx';

   // Special case for Opera on OS X emulating IE (bug 402113)
   if ((navigator.userAgent.indexOf("Opera") != -1) && (navigator.userAgent.indexOf("Opera 6") == -1)) {
     gPlatform = PLATFORM_MACOSX;
   }
} else {
   gPlatform = PLATFORM_OTHER;
   gCssClass = '';

That way, we have the defaults set first, and we only need to change gPlatform for Opera.

So, there's also a question of form here with the |if|:
   if ((navigator.userAgent.indexOf("Opera") != -1) && (navigator.userAgent.indexOf("Opera 6") == -1)) {
versus
   if ((navigator.userAgent.indexOf("Opera") != -1) && !(navigator.userAgent.indexOf("Opera 6") != -1)) {

I don't really care which one you use, but it just seems the first one is more readable, as -1 means not found, while you're notting a not in the second one. Again, your call here, as I'll r+ either way.

Comment 13

[Wil Clouser [:clouserw]]

Attachment: opera special case

Comment 14

[Wil Clouser [:clouserw]]

Thanks Reed.  This is on trunk in r9503 and will migrate towards production as time allows.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Jef, if you see any issues, don't hesitate to let us know, thanks!