Closed
Bug 402114
Opened 17 years ago
Closed 17 years ago
Fix the incorrect function prototypes of SSL handshake callbacks
Categories
(NSS :: Tools, defect)
NSS
Tools
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
5.81 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
Some of the tools under nss/cmd define their SSL handshake callbacks to return SECStatus. The correct function prototype of SSLHandshakeCallback returns void.
Attachment #287015 -
Flags: review?(nelson)
Comment 1•17 years ago
|
||
Comment on attachment 287015 [details] [diff] [review] Proposed patch r=nelson (I was going to give this bug to one of our more junior associates, but too late. :)
Attachment #287015 -
Flags: review?(nelson) → review+
Assignee | ||
Comment 2•17 years ago
|
||
I checked in the patch on the NSS trunk for NSS 3.12. Checking in SSLsample/client.c; /cvsroot/mozilla/security/nss/cmd/SSLsample/client.c,v <-- client.c new revision: 1.7; previous revision: 1.6 done Checking in SSLsample/server.c; /cvsroot/mozilla/security/nss/cmd/SSLsample/server.c,v <-- server.c new revision: 1.10; previous revision: 1.9 done Checking in SSLsample/sslsample.c; /cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.c,v <-- sslsample.c new revision: 1.12; previous revision: 1.11 done Checking in SSLsample/sslsample.h; /cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.h,v <-- sslsample.h new revision: 1.5; previous revision: 1.4 done Checking in strsclnt/strsclnt.c; /cvsroot/mozilla/security/nss/cmd/strsclnt/strsclnt.c,v <-- strsclnt.c new revision: 1.58; previous revision: 1.57 done Checking in vfyserv/vfyserv.c; /cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.c,v <-- vfyserv.c new revision: 1.16; previous revision: 1.15 done Checking in vfyserv/vfyserv.h; /cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.h,v <-- vfyserv.h new revision: 1.6; previous revision: 1.5 done Checking in vfyserv/vfyutil.c; /cvsroot/mozilla/security/nss/cmd/vfyserv/vfyutil.c,v <-- vfyutil.c new revision: 1.13; previous revision: 1.12 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in
before you can comment on or make changes to this bug.
Description
•