Fix the incorrect function prototypes of SSL handshake callbacks

RESOLVED FIXED in 3.12

Status

NSS
Tools
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

unspecified
3.12

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.81 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 287015 [details] [diff] [review]
Proposed patch

Some of the tools under nss/cmd define their SSL handshake callbacks to
return SECStatus.  The correct function prototype of SSLHandshakeCallback
returns void.
Attachment #287015 - Flags: review?(nelson)
Comment on attachment 287015 [details] [diff] [review]
Proposed patch

r=nelson

(I was going to give this bug to one of our more junior associates, but too late. :)
Attachment #287015 - Flags: review?(nelson) → review+
(Assignee)

Comment 2

10 years ago
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in SSLsample/client.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/client.c,v  <--  client.c
new revision: 1.7; previous revision: 1.6
done
Checking in SSLsample/server.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/server.c,v  <--  server.c
new revision: 1.10; previous revision: 1.9
done
Checking in SSLsample/sslsample.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.c,v  <--  sslsample.c
new revision: 1.12; previous revision: 1.11
done
Checking in SSLsample/sslsample.h;
/cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.h,v  <--  sslsample.h
new revision: 1.5; previous revision: 1.4
done
Checking in strsclnt/strsclnt.c;
/cvsroot/mozilla/security/nss/cmd/strsclnt/strsclnt.c,v  <--  strsclnt.c
new revision: 1.58; previous revision: 1.57
done
Checking in vfyserv/vfyserv.c;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.c,v  <--  vfyserv.c
new revision: 1.16; previous revision: 1.15
done
Checking in vfyserv/vfyserv.h;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.h,v  <--  vfyserv.h
new revision: 1.6; previous revision: 1.5
done
Checking in vfyserv/vfyutil.c;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyutil.c,v  <--  vfyutil.c
new revision: 1.13; previous revision: 1.12
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in before you can comment on or make changes to this bug.