Last Comment Bug 402114 - Fix the incorrect function prototypes of SSL handshake callbacks
: Fix the incorrect function prototypes of SSL handshake callbacks
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: 3.12
Assigned To: Wan-Teh Chang
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-01 14:28 PDT by Wan-Teh Chang
Modified: 2007-11-01 15:08 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (5.81 KB, patch)
2007-11-01 14:28 PDT, Wan-Teh Chang
nelson: review+
Details | Diff | Review

Description Wan-Teh Chang 2007-11-01 14:28:12 PDT
Created attachment 287015 [details] [diff] [review]
Proposed patch

Some of the tools under nss/cmd define their SSL handshake callbacks to
return SECStatus.  The correct function prototype of SSLHandshakeCallback
returns void.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-11-01 14:42:22 PDT
Comment on attachment 287015 [details] [diff] [review]
Proposed patch

r=nelson

(I was going to give this bug to one of our more junior associates, but too late. :)
Comment 2 Wan-Teh Chang 2007-11-01 15:08:27 PDT
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in SSLsample/client.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/client.c,v  <--  client.c
new revision: 1.7; previous revision: 1.6
done
Checking in SSLsample/server.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/server.c,v  <--  server.c
new revision: 1.10; previous revision: 1.9
done
Checking in SSLsample/sslsample.c;
/cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.c,v  <--  sslsample.c
new revision: 1.12; previous revision: 1.11
done
Checking in SSLsample/sslsample.h;
/cvsroot/mozilla/security/nss/cmd/SSLsample/sslsample.h,v  <--  sslsample.h
new revision: 1.5; previous revision: 1.4
done
Checking in strsclnt/strsclnt.c;
/cvsroot/mozilla/security/nss/cmd/strsclnt/strsclnt.c,v  <--  strsclnt.c
new revision: 1.58; previous revision: 1.57
done
Checking in vfyserv/vfyserv.c;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.c,v  <--  vfyserv.c
new revision: 1.16; previous revision: 1.15
done
Checking in vfyserv/vfyserv.h;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyserv.h,v  <--  vfyserv.h
new revision: 1.6; previous revision: 1.5
done
Checking in vfyserv/vfyutil.c;
/cvsroot/mozilla/security/nss/cmd/vfyserv/vfyutil.c,v  <--  vfyutil.c
new revision: 1.13; previous revision: 1.12
done

Note You need to log in before you can comment on or make changes to this bug.