402148 - ac_add_options --disable-logging breaks build

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Michael Mullin]

Build breaks if I have disable-logging enabled.

Steps to Reproduct
1. Build with the following mozconfig

mk_add_options MOZ_OBJDIR=/Users/coren/mozilla/OBJ_DIRS/optimized/ff
ac_add_options --enable-application=browser
ac_add_options --enable-optimize="-O2 -g"
ac_add_options --disable-debug
ac_add_options --enable-static
ac_add_options --disable-shared
ac_add_options --disable-libxul
ac_add_options --disable-tests
#ac_add_options --disable-logging
ac_add_options --enable-prebinding
ac_add_options --enable-strip
mk_add_options MOZ_MAKE_FLAGS=-j8

2. uncomment ac_add_options --disable-loggin
3. rebuild

Expected results
Build completes successfully

Actual Results
cc1plus: warnings being treated as errors
/Users/coren/mozilla/src/mozilla/netwerk/cookie/src/nsCookieService.cpp: In member function ‘void nsCookieService::RemoveExpiredCookies(PRInt64)’:
/Users/coren/mozilla/src/mozilla/netwerk/cookie/src/nsCookieService.cpp:2054: warning: unused variable ‘initialCookieCount’
make[6]: *** [nsCookieService.o] Error 1
make[5]: *** [libs] Error 2
make[4]: *** [libs] Error 2
make[3]: *** [libs_tier_necko] Error 2
make[2]: *** [tier_necko] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

real	2m13.734s
user	2m31.601s
sys	0m38.884s

Comment 1

[Michael Mullin]

Attachment: Potential Patch

Solves compiling problem for me

Comment 2

[Michael Mullin]

Attachment: Alternative Patch

Alternative Patch.  Reads nicer.

Comment 3

[[e-mail]]

checked this in as a bustage fix for bug 401998. thanks for filing and patching!