402181 - Better error message for captureEvents(), releaseEvents() and routeEvent()

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Per Hansen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8

This bug is an ofspring of bug #330494 and especially comment 34 (https://bugzilla.mozilla.org/show_bug.cgi?id=330494#c34) that reads:
Hello,

I wish we could reopen this bug and change the respective error messages

+UseOfCaptureEventsWarning=Use of captureEvents() is deprecated.
+UseOfReleaseEventsWarning=Use of releaseEvents() is deprecated.
+UseOfRouteEventWarning=Use of routeEvent() is deprecated.

to something like

UseOfCaptureEventsWarning=Use of captureEvents() is deprecated. To upgrade your
code, use the DOM 2 addEventListener() method. For more help
http://developer.mozilla.org/en/docs/DOM:element.addEventListener

UseOfReleaseEventsWarning=Use of releaseEvents() is deprecated. To upgrade your
code, use the DOM 2 removeEventListener() method. For more help
http://developer.mozilla.org/en/docs/DOM:element.removeEventListener

UseOfRouteEventWarning=Use of routeEvent() is deprecated. To upgrade your code,
use the DOM 2 dispatchEvent() method. For more help
http://developer.mozilla.org/en/docs/DOM:element.dispatchEvent

The spirit behind the new messages is to be as helpful as possible.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Philip Chee]

Changing component to Core->DOM:Events

Comment 2

[Gérard Talbot]

CONFIRMING

Comment 3

[Gérard Talbot]

Voting for this bug :)

Comment 4

[timeless]

Attachment: per reporter...

Comment 5

[Gérard Talbot]

Timeless,

in your patch you give
(...) For more help http://developer.mozilla.org/en/docs/DOM:element.addEventListeners

but it should be rather/instead 

(...) For more help http://developer.mozilla.org/en/docs/DOM:element.addEventListener

No trailing "s"

Comment 6

[timeless]

Attachment: per reporter...

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 312859 [details] [diff] [review]
per reporter...

looks ok to me

Comment 8

[timeless]

Comment on attachment 312859 [details] [diff] [review]
per reporter...

note: it is ok for l10n to fail to catch this change, it's just an improvement to en-US. If they don't want to ship better messages, that's fine. If they have time, that's also nice.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312859 [details] [diff] [review]
per reporter...

a1.9=beltzner

Comment 10

[timeless]

Comment on attachment 312859 [details] [diff] [review]
per reporter...

mozilla/dom/locales/en-US/chrome/dom/dom.properties 	1.13

Comment 11

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #8)
> (From update of attachment 312859 [details] [diff] [review])
> note: it is ok for l10n to fail to catch this change, it's just an improvement
> to en-US. If they don't want to ship better messages, that's fine. If they have
> time, that's also nice.

At least post to .l10n about this, please, to give them more chances to catch this change.

Comment 12

[Axel Hecht [:Pike]]

What's going on here? I thought we're frozen.

Comment 13

[Mike Connor [:mconnor]]

This isn't adding strings or making semantic changes (as least in the sense that the error message means anything different).  The string names weren't changed, so other locales will not break or fail.  Don't know if I have a strong opinion either way on this at this point, other than to say that this shouldn't be any different from a typo fix from the perspective of the localizers.

Comment 14

[Axel Hecht [:Pike]]

There have been several localizers wondering what to do about this, and they really should worry about different things. We shouldn't be taking RFEs on strings anymore, even if they're just rewording an existing message.

Typos are different, because that makes 2 locales think, string improvements like this one are work for 60. Even if it's not required work, even ignoring it is too much of a hassle right now.

At least that's my take.