402284 - Switching between designMode and contentEditable broken

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

When turning on designMode on a page that has contentEditable elements the elements that don't have a contentEditable attribute can't be edited. This is a regression caused by the patch for bug 389350.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Testcase

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Untested patch

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

I've tested Peter's patch, and it does fix the case he pointed out. It also fixes the case that Karl pointed out here: https://bugzilla.mozilla.org/show_bug.cgi?id=389350#c21

Maybe we should push this into 1.9?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You mean M9? It should certainly block 1.9.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yes, I mean M9; seeing as we were trying to get the fix for 389350 into M9, we may  as well put this patch in that fixes it properly.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Setting TM=M9.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 287177 [details] [diff] [review]
Untested patch

I've tested this patch, and it WFM, can you review this so we can push it into M9 please Brade?

Comment 8

[Peter Van der Beken [:peterv]]

Since I wrote the patch I don't think I should review, but Chris should be able to imho.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 287177 [details] [diff] [review]
Untested patch

Looks good to me.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 287177 [details] [diff] [review]
Untested patch

a=beltzner for M9

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9a9pre) Gecko/2007110604 Minefield/3.0a9pre and on Tiger as well. I verified using the testcase attached to the bug.