40245 - can't load the Advanced pref panes, get JS error

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

here's the error I get:

JavaScript error:
chrome://global/content/nsWidgetStateManager.js line 126: elements[i] has no pro
perties

Comment 1

[(not reading, please use [e-mail] instead)]

marking nsbeta2

Comment 2

[(not reading, please use [e-mail] instead)]

ben looks busy on the classic skin.  (I can't wait for it!)  

I think I can fix this one.

sorry for the bug noise, ben.

Comment 3

[(not reading, please use [e-mail] instead)]

marking m16, working on this now.

Comment 4

[(not reading, please use [e-mail] instead)]

fix in hand, will check in when smoketest verifications are done.

here's the fix:

Index: pref-advanced.xul
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-advanced.xul,v
retrieving revision 1.39
diff -r1.39 pref-advanced.xul
35c35
<     _elementIDs = ["advancedAlwaysLoadImages", "advancedJavaAllow",
"javascriptAllowMailNews", "javascriptEnabled", "CSSAllow", "advancedMailFTP"];
---
>     _elementIDs = ["advancedAlwaysLoadImages", "advancedJavaAllow",
"javascriptAllowMailNews", "javascriptEnabled", "advancedMailFTP"];

the fix for http://bugzilla.mozilla.org/show_bug.cgi?id=39552 removed the
CSSAllow checkbox, but it was not removed the list of _elementIDs

ben, I think we should make nsWidgetStateManager.js more robust, and able to
handle problems like this.  (we should dump an error to console, but gracefully
handle it and move on.)

I'll log a bug on you for that.

Comment 5

[(not reading, please use [e-mail] instead)]

fixed.

Comment 6

[sairuh (rarely reading bugmail)]

woo! verified using 2000.05.24.08 [opt commercial] on linux, mac and winnt.