402482 - No scroll-bar for all-day events

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Nacho]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8.1.9) Gecko/20071025 Firefox/2.0.0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8.1.8pre) Gecko/20071023 Sunbird/0.7

There is no scroll-bar for all-day events. If any day there any "many" (over 20) events with no specific time (tagged as all-day events),the timed events cannot be seen, as there is no scroll bar for all-day events, so they grow too much.

If the amount of all-day events is no so big, you still can see timed events, but in a very limited part of the screen.

This happens in Day View and Week View, but Month week is OK, and also Multi-Week view is OK.


Reproducible: Always

Steps to Reproduce:
1. Add +20 all-day events
2. Choose day view or week view
3.
Actual Results:  
Timed events cannot be seen

Expected Results:  
All-day events should have a scroll bar, whether shared with timed events or not

Comment 1

[Omar Bajraszewski]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.10pre) Gecko/20071105 Calendar/0.8pre

Comment 2

[Lars Wohlfahrt (thetux)]

Confirmed with Thunderbird 2.0.0.9 / Lightning 0.8pre (build 2007121903) on Windows XP

Screenshot:
http://img180.imageshack.us/my.php?image=missingscrollfunctionfomx0.png

Comment 3

[Simon Paquet [:sipaq]]

Not going to happen for 0.8.

Comment 4

[Lars Wohlfahrt (thetux)]

Lame workaround: Everything is shown in printing preview

Comment 5

[Andreas Treumann]

This bug makes it hard for e.g. HR people to get an employee vacation overview and use the calendar for daily work in parallel.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add scrollbars - v1

This patch takes care. Might need some tweaking on mac.

* Normal view: Scrollbar appears above the views-scrollbar if allday box is larger
  than 120px.
* Rotated view: Box for allday events is expanded to make it usable.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Screenshot - Normal view

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Screenshot - Rotated view

Comment 9

[Lars Wohlfahrt (thetux)]

This patch keeps Lightning workable on smaller screens, so I think this is a really important bugfix. The 120px limit could be further improved, for example with a comparative limit bound to the screen resolution.

Comment 10

[Nacho]

Good work, Philipp!!!

But as Lars, I think it should not be a strict 120 px limit, but a screen percentage, or, even better, customizable at Preferences.

For example, I use to have more "all-day" events (things to be done at any time - usually over 15) than timed events (things to be done at fixed moments - barely 5 or 6), so I would choose to leave more room for all-day events than most people would do.

Comment 11

[Christian Jansen]

Comment on attachment 310604 [details] [diff] [review]
Add scrollbars - v1

looks good to me. r=christian

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I could try to play around with percentages. If you want this changed, you can always use a useChrome.css that contains the correct rule (i.e modify the max-height of the headerdaybox).

Comment 13

[Nacho]

Good to know. Changing the CSS is an easy way to adapt. Thanks a lot, Philipp!

Comment 14

[Stefan Sitter [:ssitter]]

How does the rotated view behaves? What happens if there are too many events? What happens if there are events with a long title?

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to comment #14)
> How does the rotated view behaves? What happens if there are too many events?
> What happens if there are events with a long title?
> 

I didn't change the rotated view much since I'm not quite sure how its best handled. All I did was to change the width of the box with allday events. This means the events will still crop if they have a long title and the views will expand to be much longer if there are too many events.

Christian, if you have a good idea how to solve this, feel free to comment.

Comment 16

[Berend Cornelius]

Basically this patch is a good improvement!

>+calendar-header-container[orient="horizontal"] {
>+  border-bottom: 1px solid #3F7D91;
>+}
>+calendar-header-container[orient="horizontal"] {
>+  border-bottom: 1px solid #3F7D91;
>+}

These rules are duplicate (in both css files):

>+          var startDate = calGetStartDate(aEvent);
>+          var endDate = calGetEndDate(aEvent);
>+          if (startDate && startDate.isDate ||
>+              endDate && endDate.isDate) {
>+              // If this is an all day event, then the header with allday
>+              // events could possibly get a scrollbar. Readjust them.
>+              this.adjustScrollBarSpacers();
>+          }

This logic also turns up twice. I would consolidate that.

1) I noticed two further issues: Scrolling the mouse by weel -usually controlled by the DOMMouseScroll handler does not work for the srollbar in the  header when you move the mouse next to it. If you want to we can handle this in a follow up issue.

2) Under Sunbird there is also a horizontal scrollbar displayed underneath the header. Adding 
overflow-x: auto;
to the .css rule calendar-month-view-column-header seemed to resolve this problem.
I think we should file a follow-up to provide a scrollbar for a rotated view.
Maybe also to have the max-height of the header handled in percentage (or maybe font-size based?)

Comment 17

[Berend Cornelius]

Comment on attachment 310604 [details] [diff] [review]
Add scrollbars - v1

patch granted; r=berend with the objected issues being addressed especially the horizontal scrollbar under Sunbird.

Comment 18

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add scrollbars - v2

Patch with berend's comments fixed.

I fixed the scoll issue also, but unfortunately I couldn't make it scroll by exactly one event box's height due to problems with toolkit and/or the bindings.

Checkin in...

Comment 19

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 20

[Andreas Treumann]

Checked in lightning 2008061918 and Sunbird 20080619 -> VERIFIED