Closed
Bug 402536
Opened 18 years ago
Closed 18 years ago
Provide a protocol handler implementation for the nsLDAPURL in preparation for use with toolkit's password manager.
Categories
(Directory Graveyard :: LDAP XPCOM SDK, defect)
Directory Graveyard
LDAP XPCOM SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
3.97 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Toolkit's password manager makes (good) use of the ioService to get nsIURIs etc.
For the LDAP parts, we need a nsLDAPProtocolHandler. We already have one in the experimental code, which is also used for the nsIChannel implementation. As we don't want the nsIChannel implementation at the moment, I'm proposing that we build with the protocol handler and just error out if anyone tries to create a new channel base on ldap.
We also should implement GetHostPort for nsLDAPURL I'm not sure if we will need it or not, but I think it should be there.
Attaching patch.
Attachment #287399 -
Flags: superreview?(bienvenu)
Attachment #287399 -
Flags: review?(bienvenu)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 287399 [details] [diff] [review]
The fix
thx, Mark
Attachment #287399 -
Flags: superreview?(bienvenu)
Attachment #287399 -
Flags: superreview+
Attachment #287399 -
Flags: review?(bienvenu)
Attachment #287399 -
Flags: review+
|
Assignee | |
Comment 2•18 years ago
|
||
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•