Closed
Bug 402550
Opened 18 years ago
Closed 18 years ago
Change needed for ARM hardware platform for QNX (Photon) port
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mfeil, Assigned: mfeil)
Details
(Keywords: fixed1.8.1.12)
Attachments
(2 files)
19.01 KB,
patch
|
benjamin
:
review+
dveditz
:
approval1.8.1.10-
dveditz
:
approval1.8.1.12+
|
Details | Diff | Splinter Review |
18.63 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (Photon; U; QNX x86pc; en-US; rv:1.8.1.5pre) Gecko/0000000000 BonEcho/2.0.0.5pre
The Javascript-to-native calling interface needs to be implemented for QNX Neutrino ARM targets. Without this most JS does not work.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Assignee | ||
Comment 1•18 years ago
|
||
The changes in this patch were made in a way so that non-QNX code is not affected.
Attachment #287417 -
Flags: approval1.8.1.10?
Comment 2•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
Please get appropriate reviews and land on trunk before asking for branch check-in approval.
Would also inspire more confidence if this were assigned to a person. Since you patched it that probably should be you.
Attachment #287417 -
Flags: approval1.8.1.10?
Assignee | ||
Updated•18 years ago
|
Attachment #287417 -
Attachment description: QNX-only proposed changes for ARM platform → QNX-only proposed changes for ARM platform, 1.8 branch
Assignee | ||
Comment 3•18 years ago
|
||
For QNX JS->native calls
Attachment #287887 -
Flags: review?(benjamin)
Assignee | ||
Updated•18 years ago
|
Attachment #287417 -
Flags: review?(benjamin)
Updated•18 years ago
|
Assignee: nobody → maxf
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
I did not carefully review the assembly because I don't know ARM, so I'm trusting you to have it right.
Attachment #287417 -
Flags: review?(benjamin) → review+
Updated•18 years ago
|
Attachment #287887 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 5•18 years ago
|
||
Landed on trunk, waiting for branch approval:
Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v <-- Makefile.
in
new revision: 1.95; previous revision: 1.94
done
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.
cpp,v
done
Checking in xptcinvoke_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.cpp,v <--
xptcinvoke_nto_arm.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.c
pp,v
done
Checking in xptcstubs_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.cpp,v <--
xptcstubs_nto_arm.cpp
initial revision: 1.1
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
QNX needs this checked into the MOZILLA_1_8_BRANCH for Firefox 2.0-based browser.
Attachment #287417 -
Flags: approval1.8.1.11?
Comment 7•18 years ago
|
||
branch status is handled through request flags and "fixed1.8.1.x" keywords, bug is fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Attachment #287417 -
Flags: approval1.8.1.10?
Comment 8•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
approved for 1.8.1.10, a=dveditz. We're building soon (tomorrow?) so actual landing might be in 1.8.1.11 depending on how soon you get to it.
Attachment #287417 -
Flags: approval1.8.1.10? → approval1.8.1.10+
Comment 9•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
Will have to wait for next time
Attachment #287417 -
Flags: approval1.8.1.10+ → approval1.8.1.10-
Comment 10•18 years ago
|
||
Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch
approved for 1.8.1.12, a=dveditz for release-drivers
Please land on the early side of the release so it doesn't miss the code-release window.
Attachment #287417 -
Flags: approval1.8.1.12? → approval1.8.1.12+
Assignee | ||
Comment 11•18 years ago
|
||
Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v <-- Makefile.
in
new revision: 1.80.4.5; previous revision: 1.80.4.4
done
Checking in xptcinvoke_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.cpp,v <--
xptcinvoke_nto_arm.cpp
new revision: 1.1.4.1; previous revision: 1.1
done
Checking in xptcstubs_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.cpp,v <--
xptcstubs_nto_arm.cpp
new revision: 1.1.4.1; previous revision: 1.1
done
Updated•18 years ago
|
Keywords: fixed1.8.1.12
Updated•17 years ago
|
OS: Other → Neutrino
You need to log in
before you can comment on or make changes to this bug.
Description
•