402550 - Change needed for ARM hardware platform for QNX (Photon) port

Status: RESOLVED FIXED

Description

[Max Feil - mfeil%qnx.com]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (Photon; U; QNX x86pc; en-US; rv:1.8.1.5pre) Gecko/0000000000 BonEcho/2.0.0.5pre

The Javascript-to-native calling interface needs to be implemented for QNX Neutrino ARM targets. Without this most JS does not work.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Max Feil - mfeil%qnx.com]

Created attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

The changes in this patch were made in a way so that non-QNX code is not affected.

Comment 2

[Daniel Veditz [:dveditz] OOO until Aug 20]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

Please get appropriate reviews and land on trunk before asking for branch check-in approval.

Would also inspire more confidence if this were assigned to a person. Since you patched it that probably should be you.

Comment 3

[Max Feil - mfeil%qnx.com]

Created attachment 287887 [details] [diff] [review]
QNX-only proposed changes for ARM platform, TRUNK

For QNX JS->native calls

Comment 4

[Benjamin Smedberg]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

I did not carefully review the assembly because I don't know ARM, so I'm trusting you to have it right.

Comment 5

[Max Feil - mfeil%qnx.com]

Landed on trunk, waiting for branch approval:

Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.
in
new revision: 1.95; previous revision: 1.94
done
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.
cpp,v
done
Checking in xptcinvoke_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.cpp,v  <--
  xptcinvoke_nto_arm.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.c
pp,v
done
Checking in xptcstubs_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.cpp,v  <--
 xptcstubs_nto_arm.cpp
initial revision: 1.1

Comment 6

[Max Feil - mfeil%qnx.com]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

QNX needs this checked into the MOZILLA_1_8_BRANCH for Firefox 2.0-based browser.

Comment 7

[Daniel Veditz [:dveditz] OOO until Aug 20]

branch status is handled through request flags and "fixed1.8.1.x" keywords, bug is fixed on trunk

Comment 8

[Daniel Veditz [:dveditz] OOO until Aug 20]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

approved for 1.8.1.10, a=dveditz. We're building soon (tomorrow?) so actual landing might be in 1.8.1.11 depending on how soon you get to it.

Comment 9

[Daniel Veditz [:dveditz] OOO until Aug 20]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

Will have to wait for next time

Comment 10

[Daniel Veditz [:dveditz] OOO until Aug 20]

Comment on attachment 287417 [details] [diff] [review]
QNX-only proposed changes for ARM platform, 1.8 branch

approved for 1.8.1.12, a=dveditz for release-drivers

Please land on the early side of the release so it doesn't miss the code-release window.

Comment 11

[Max Feil - mfeil%qnx.com]

Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.
in
new revision: 1.80.4.5; previous revision: 1.80.4.4
done
Checking in xptcinvoke_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_nto_arm.cpp,v  <--
  xptcinvoke_nto_arm.cpp
new revision: 1.1.4.1; previous revision: 1.1
done
Checking in xptcstubs_nto_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_nto_arm.cpp,v  <--
 xptcstubs_nto_arm.cpp
new revision: 1.1.4.1; previous revision: 1.1
done