402597 - AT-SPI Accessibility:Event.user_data None for ARIA tooltips/alerts

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Scott Haeger]

The tooltip seen here http://www.mozilla.org/access/dhtml/new/tooltip has the following debug for the Accessibility::Event object.  Note that the any_data field, the target of the object:children-changed:add event, is None. 

source =  [paragraph | ]
type = object:children-changed:add:system
any_data = None
detail1 = 2
detail2 = 0 

This is also the case for dojo tooltips (actually alerts) seen here http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Tooltip.html and the tooltips linked from http://developer.mozilla.org/en/docs/Accessible_DHTML#Supported_roles .

A strange oddity is that object:children-changed:add events for the live region examples were broken (pre-pyatspi migration for Orca) with respect to user_data, but now they work.  Beyond event type, I am not sure how else the two issues are related.

Comment 1

[Scott Haeger]

Accessibility::Event.any_data is correct if you change the 'span' to a 'p' for the tooltip in http://www.mozilla.org/access/dhtml/new/tooltip .  Please fix span issue (tough one I'm sure) or change the example, possibly mentioning <span> unsupported.

Now investigating why UIUC and dojo examples are unsupported with regard to any_data.

Comment 2

[Scott Haeger]

The UIUC examples seen here http://test.cita.uiuc.edu/aria/tooltip/view_xhtml.php?title=Tooltip%20Example%201&ginc=includes/tooltip1_xhtml.inc&gcss=css/tooltip1_xhtml.css&gjs=js/tooltip1_xhtml.js,../js/widgets_xhtml.js,../js/globals.js and http://test.cita.uiuc.edu/aria/tooltip/view_html.php?title=Tooltip%20Example%201&ginc=includes/tooltip1.inc&gcss=css/tooltip1.css&gjs=js/tooltip1.js,../js/widgets.js,../js/globals.js do not trigger any AT-SPI events during the tooltip showing sequence.

Comment 3

[Scott Haeger]

The dojo example seen here http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Tooltip.html also uses a span for the tooltip.  However, changing it to a <p> did not fix the problem.  I tried several markup changes to the surrounding tooltip markup, all with no luck.  The event.any_data field is always None for object:children-changed:add:system events.  Also of note is that the object:text-changed:inserted:system events appear to be of little worth to Orca for tooltip announcements.

Comment 4

[Aaron Leventhal]

See also bug 402049.

Comment 5

[Scott Haeger]

The UIUC tooltip examples can be fixed by changing their hiding/showing logic to use display:[none|inline] instead of moving the tooltip way off the screen.

Comment 6

[Ginn Chen]

We should not use
accessible->GetIndexInParent(&indexInParent);
in  nsAccessibleWrap::FireAtkShowHideEvent

because for ATK we don't want to include text leaf nodes as children.

Comment 7

[Ginn Chen]

Attachment: patch

reuse the code above

Comment 8

[Aaron Leventhal]

Comment on attachment 299979 [details] [diff] [review]
patch

Nice work Ginn! I bet this solves a lot of other issues with show/hide events!

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 299979 [details] [diff] [review]
patch

a1.9+=damons

Comment 10

[Aaron Leventhal]

Checked in for Ginn.

Comment 11

[Scott Haeger]

This bug and it's sister bug #402049 are both looking much better.