402680 - document.activeElement returns wrong node

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[José Jeria]

Attachment: Testcase

Steps to reproduce:

1. Run testcase
2. Dismiss alert dialog saying "activeElement is [object HTMLHtmlElement]"
3. View source

Note that the focus on the input element is set using window.onload. The alert comes before the window.onload. It should alert null, since the the window.onload has not triggered yet. IE alerts null.

Comment 1

[José Jeria]

Attachment: Testcase (using a three second timer)

This bug is also visible using a timer (3 seconds in this case) to set the focus on the text field.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

http://www.whatwg.org/specs/web-apps/current-work/#activeelement
http://www.whatwg.org/specs/web-apps/current-work/#the-body0

I think we want to return null when there is no body (yet). 
That is what html5 defines and that is what IE seems to do here.
Hixie also suggested that.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

.activeElement is a new feature in 1.9, so better to ship it with
more compliance with IE.

Comment 4

[Boris Zbarsky [:bzbarsky]]

That doesn't make much sense for non-HTML documents, imo.  Please do read the discussion in the bug that checked in this code...

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I did, and comment 5 there was really the only one commenting about this.
It doesn't make much sense to return null with htmldocuments and root element with non-html-documents. .activeElement is IEism, so IMO, we should work
as closely as possible as IE.
We could also close this as wontfix, but perhaps need to document somewhere that
we don't follow html5 and work a bit different way than IE.
Though I could also try to change HTML5 to follow gecko's current behavior.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> It doesn't make much sense to return null with htmldocuments and root element
> with non-html-documents.

Why not?  We do special things like that with body all over.  I'm perfectly happy to do just that.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: return null only with html documents

I don't like non-html-documents working in a different way than html documents,
but in this case I can perhaps blame IR :p

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #7)
> I can perhaps blame IR :p
er, IE. 

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 287693 [details] [diff] [review]
return null only with html documents

This I buy.  Check in some testcases, please!

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 287693 [details] [diff] [review]
return null only with html documents

I'll check in some mochitests if I get approval.

Comment 11

[José Jeria]

Verified fixed with build: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007111312 Minefield/3.0b2pre