402703 - Favicons for tag matches in autocomplete aren't resized

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Wesley Johnston (:wesj)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007110605 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007110605 Minefield/3.0a9pre

If a tagged page has a larger than normal size favicon, its icon isn't scaled down in the autocomplete results. This only happens when the result matches a tag, and not when you're matching something else in the URL or Title.

Reproducible: Always

Steps to Reproduce:
1. Tag a site with an oversized favicon
2. Type the tag into the urlbar
3.
Actual Results:  
As soon as you finish the tag the icon size jumps up to large

Expected Results:  
The icon should never change.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Screenshot of the oversized icon

Comment 2

[Ria Klaassen (not reading all bugmail)]

Shouldn't this be the places component?
I can confirm that this problem exists with latest trunk, Windows XP.

Comment 3

[Justin Dolske [:Dolske]]

I don't think 389273 is a dependency here; it will avoid the problem in this bug by reencoding large (in bytes) images to 16x16, but a small (in bytes) image that's bigger than 16x16 would still exhibit this problem.

Comment 4

[(not reading, please use [e-mail] instead)]

I think this is something else, specifically, I need to fix some css.

thanks for the bug report!

Comment 5

[(not reading, please use [e-mail] instead)]

the fix is to mozilla/browser/themes/*instripe/browser/browser.css

for testing, I'm using http://www.nps.gov/alcatraz/

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: screenshot after the fix

Comment 8

[Wesley Johnston (:wesj)]

This might not even be necessary to fix here, as Bug #399664 is moving the tree into a richlist box, and the image container there seems to be a fixed size. I was just going to wait for it to land and hopefully mark this as fixed.

Comment 9

[(not reading, please use [e-mail] instead)]

wesley is right, this is not an issue with the patch from bug #399664, but I still think we should fix it on the trunk.

when #399664 lands, this css change would go away.

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.92; previous revision: 1.91
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.130; previous revision: 1.129
done

Comment 11

[(not reading, please use [e-mail] instead)]

backed out, tree's closed

Comment 12

[(not reading, please use [e-mail] instead)]

waiting for the tree...

Comment 13

[(not reading, please use [e-mail] instead)]

re-landed.

fix re-landed.

Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <-- 
browser.css
new revision: 1.94; previous revision: 1.93
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <-- 
browser.css
new revision: 1.132; previous revision: 1.131
done

Comment 14

[(not reading, please use [e-mail] instead)]

steps to reproduce / verify this

1)  visit http://www.nps.gov/favicon.ico to make sure the favicon is still 32x32
2)  visit http://www.nps.gov/alcatraz
2)  bookmark that page by clicking the "star" button (but don't give it a tag yet)
3)  in the url bar, type "alca", you should get a result for http://www.nps.gov/alcatraz with a 16x16 version of the favicon
4) re-visit http://www.nps.gov/alcatraz
5) click the "star" button and tag it with test
6) now type in "test" into the url bar, you should get a result for http://www.nps.gov/alcatraz

before this fix, the favicon wouldn't be resized to 16x16 properly

after this fix, it will be properly resized to 16x16

note, you can also use neogaf.com

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: favicon for upcoming testcase

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: test case

Comment 17

[(not reading, please use [e-mail] instead)]

note to qa:

for verification and for litmus, you can use https://bugzilla.mozilla.org/attachment.cgi?id=288215

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5001

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112016 Minefield/3.0b2pre with the testcase in comment 14 / comment 18.