Closed Bug 402706 Opened 13 years ago Closed 13 years ago

change names of new width keywords

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

In bug 311415 I added support for some new keywords on the width property.  The CSS WG just agreed to add them to css3-box, but changed the names (which I was never happy with anyway).  So we should change our -moz-prefixed names to match the new names, since we haven't shipped the -moz-prefixed names in any release yet.

-moz-intrinsic => -moz-max-content
-moz-min-intrinsic => -moz-min-content
-moz-fill => -moz-available
-moz-shrink-wrap => -moz-fit-content
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Attached patch patchSplinter Review
I generated this patch by running

find . -type f -exec perl -pi /builds/trunk/working/subst.pl {} \;

in mozilla/layout, where subst.pl contained:

s/-moz-fill/-moz-available/g;
s/_moz_fill/_moz_available/g;
s/NS_STYLE_WIDTH_FILL/NS_STYLE_WIDTH_AVAILABLE/g;
s/-moz-intrinsic/-moz-max-content/g;
s/_moz_intrinsic/_moz_max_content/g;
s/NS_STYLE_WIDTH_INTRINSIC/NS_STYLE_WIDTH_MAX_CONTENT/g;
s/-moz-min-intrinsic/-moz-min-content/g;
s/_moz_min_intrinsic/_moz_min_content/g;
s/NS_STYLE_WIDTH_MIN_INTRINSIC/NS_STYLE_WIDTH_MIN_CONTENT/g;
s/-moz-shrink-wrap/-moz-fit-content/g;
s/_moz_shrink_wrap/_moz_fit_content/g;
s/NS_STYLE_WIDTH_SHRINK_WRAP/NS_STYLE_WIDTH_FIT_CONTENT/g;

and then I hand-edited:
layout/base/nsStyleConsts.h, to line up the whitespace
layout/style/nsCSSKeywordList.h, to put the lines back in alphabetical order
Attachment #288753 - Flags: superreview?(bzbarsky)
Attachment #288753 - Flags: review?(bzbarsky)
Comment on attachment 288753 [details] [diff] [review]
patch

r+sr=bzbarsky
Attachment #288753 - Flags: superreview?(bzbarsky)
Attachment #288753 - Flags: superreview+
Attachment #288753 - Flags: review?(bzbarsky)
Attachment #288753 - Flags: review+
Fix checked in to trunk.

Adding dev-doc-needed since we need to search-replace the docs on bug 311415 with this change.
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Flags: in-testsuite-
I fixed one last place; marking this as complete.
You need to log in before you can comment on or make changes to this bug.