402807 - Elements on Cyberpresse.ca are displaced to the left

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Gabriel Chadwick]

On Cyberpresse.ca the width of the template is to short some elements are overflowing like the menu. Look at following screen shots. Regression because it works on 1.8 branch but not on trunk.

Getting it with Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9a9pre) Gecko/2007110605 Minefield/3.0a9pre ID:2007110605

Comment 1

[Gabriel Chadwick]

Attachment: Correct layout

Comment 2

[Gabriel Chadwick]

Attachment: Incorrect layout

Comment 3

[Gabriel Chadwick]

Finally it looks more like these elements are to much to the left.

Comment 4

[Gabriel Chadwick]

Regression range for this is 2007-07-03-04 to 2007-07-04-04. Confirming bug to get more attention.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Needs Martijn love!

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase

It seems that the background-image of the page doesn't take it into account when the page has a scrollbar.

Comment 7

[Martijn Wargers (dead)]

Gabriel, thanks for the regression range, looking at bonsai:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-03-04&maxdate=2007-07-04-04&cvsroot=%2Fcvsroot
It seems to me a regression from bug 380816, then.

Comment 8

[Martijn Wargers (dead)]

Attachment: reftest

Comment 9

[Gabriel Chadwick]

IMO this should be fixed for beta3 and in consequence it should get an P2 upgrade.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Regression from Mats' patch.

Comment 11

[Martijn Wargers (dead)]

RCS file: /cvsroot/mozilla/layout/reftests/bugs/402807-1.html,v
done
Checking in 402807-1.html;
/cvsroot/mozilla/layout/reftests/bugs/402807-1.html,v  <--  402807-1.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/layout/reftests/bugs/402807-1-ref.html,v
done
Checking in 402807-1-ref.html;
/cvsroot/mozilla/layout/reftests/bugs/402807-1-ref.html,v  <--  402807-1-ref.htm
l
initial revision: 1.1
done
Checking in reftest.list;
/cvsroot/mozilla/layout/reftests/bugs/reftest.list,v  <--  reftest.list
new revision: 1.290; previous revision: 1.289
done

I checked the reftest in as a known fail.
So as soon as this bug gets fixed, that has to be changed in the reftest.list file.

Comment 12

[Martijn Wargers (dead)]

This also seems to be a problem at http://sierkbornemann.de/

Comment 13

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Adjust for scrollbars.  This fixes all URLs, testcases and reftests.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 301040 [details] [diff] [review]
Patch rev. 1

Eli is not active.

Comment 15

[Martijn Wargers (dead)]

Mats, the patch can be checked in, right?

Comment 16

[Mats Palmgren (inactive)]

mozilla/layout/base/nsCSSRendering.cpp 	3.340

The reftest fails on Mac (qm-xserve01) so I commented it out.
Looking at the Tinderbox log I can't see any difference between
the TEST image and the REFERENCE image.  FWIW, the test works
on qm-win2k3-01 and qm-centos5-01 and it works fine locally
on Linux, so I'm not sure what the problem is on qm-xserve01.

-> FIXED

Comment 17

[Gabriel Chadwick]

Verified on Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9b4pre) Gecko/2008020708 Minefield/3.0b4pre ID:2008020708

Comment 18

[Sierk Bornemann]

The fix is verified/confirmed for Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9b4pre) Gecko/2008020708 Minefield/3.0b4pre.

The glitch with the false adjustment of the banner left-handed on http:/sierkbornemann.de/ is fixed now. Thanks! :-)

Comment 19

[Phil Ringnalda (:philor)]

Uncommented the reftest in https://hg.mozilla.org/integration/mozilla-inbound/rev/5edb40fdafe5, since it doesn't seem to fail now (or fails intermittently and not very often, a thing which we now have better ways to deal with).

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5edb40fdafe5