403017 - (fx3-wsl10n-ar) Fx 3 web services review for Arabic (ar-JO)

Status: VERIFIED FIXED

(Mozilla Localizations :: ar / Arabic, defect)

Description

[Mic Berman]

checking default list of web services
please confirm the list of search plug-ins, default should be:
google
yahoo
amazon
answers
creative commons
ebay
wikipedia

can you confirm RSS feed: BBC
confirm RSS readers: my yahoo, bloglines, igoogle

thanks

Comment 1

[Mic Berman]

ping

Comment 2

[Ayman Hourieh]

Confirmed. We are using the default services that ship with the English version. We may only make the Wikipedia plugin search the Arabic version of Wikipedia instead of English.

Sorry for the delay...

Comment 3

[Mic Berman]

thank you. have you seen our new guidelines for localizing these services?
http://wiki.mozilla.org/Firefox_web_services_guidelines

Comment 4

[Mic Berman]

ping: 
it would be great if you used the arabic version of Wikipedia, they appear to have at least 10,000 articles which is great.
do you need to attach a new patch for that?

Comment 5

[Ayman Hourieh]

Looks like I also need to remove files from ar/browser/searchplugins. I will attach a patch to 1) remove these files. 2) add a search plugin for Arabic Wikipedia. Will do so this weekend at most.

Comment 6

[Mic Berman]

ping

Comment 7

[Ayman Hourieh]

Attachment: Search plugins for Arabic Firefox 3.0

Comment 8

[Ayman Hourieh]

Hi,

I've attached a patch that removes unneeded search plugins and adds a search plugin for Arabic Wikipedia.

Thank you.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 305254 [details] [diff] [review]
Search plugins for Arabic Firefox 3.0

>Index: ar/browser/searchplugins/wikipedia-ar.xml

>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>+<ShortName>ويكيبيديا</ShortName>
>+<Description>ويكيبيديا، الموسوعة الحرة</Description>

These values should be the same as in the official Wikipedia plugin (http://ar.wikipedia.org/w/opensearch_desc.php), to make sure that users don't get prompted to re-add the engine when they're visiting Wikipedia.

>+<Url type="text/html" method="GET" template="http://ar.wikipedia.org/wiki/%D8%AE%D8%A7%D8%B5:%D8%A8%D8%AD%D8%AB">

>+  <Param name="go" value="Article"/>

This parameter makes us jump to the article directly if a suitable match is found, right? We don't do that in the en-US version, I think it's probably best to be consistent.

>+  <Param name="sourceid" value="mozilla-20"/>

Where does this parameter come from? The en-US version uses <Param name="sourceid" value="Mozilla-search"/>, seems like we should be consistent unless there is a specific reason here.

Wikipedia supports suggestions now, you should add the suggest URI that's in their plugin:

<Url type="application/x-suggestions+json" method="GET"
     template="http://ar.wikipedia.org/w/api.php">
  <Param name="action" value="opensearch"/>
  <Param name="search" value="{searchTerms}"/>
</Url>

>+<SearchForm>http://ar.wikipedia.org/</SearchForm>

I think we usually point these to the /Search page, so http://ar.wikipedia.org/wiki/%D8%AE%D8%A7%D8%B5:%D8%A8%D8%AD%D8%AB .

The rest of this patch looks fine. I will r+ a version with these comments addressed. Thanks!

Comment 10

[Ayman Hourieh]

Attachment: Searchplugins for Arabic (revised)

Comment 11

[Ayman Hourieh]

Thanks for the comments. I've addressed them and created a new patch. Please have another look.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 305327 [details] [diff] [review]
Searchplugins for Arabic (revised)

>Index: ar/browser/searchplugins/wikipedia-ar.xml

Looks like you lost the <InputEncoding>UTF-8</InputEncoding> in this file when making the other changes. UTF-8 is the default, but it's best to keep it in so that it's explicit.

r=me with that change made.

Comment 13

[Ayman Hourieh]

Attachment: Search plugins for Arabic (r3)

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Ayman: please go ahead and land that patch.

Comment 15

[Ayman Hourieh]

Patch was committed, thank you.

Should I mark this bug as fixed?

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Yes, looks fixed to me.

Comment 17

[Axel Hecht [:Pike]]

I wonder if we should still fix the <ShortName> in wikipedia-ar.xml to match http://ar.wikipedia.org/, i.e., be "ويكيبيديا (ar)".

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Yeah. The wikipedia shortnames seem to be changing as we're landing the plugins, though, it's hard to keep up :/ Hopefully they've settled on a common format and will stick to it. 

Comment 19

[Ayman Hourieh]

What's the current status of this? Have the Wikipedia short names been stabilized? Should I create a patch to change the plugin?

Comment 20

[Axel Hecht [:Pike]]

Yeah, they're going for (ab-CD) now, for all that I checked. In case of Arabic, that'd be "ويكيبيديا (ar)".

Mind filing a new bug for that, and make that block your release bug? I'd like to keep the noise down on the bugs that are actually about deciding the set, and move the "bugs" in particular engines out to separate bug, if they're dealt with separately.

Comment 21

[Ayman Hourieh]

(In reply to comment #20)
> Yeah, they're going for (ab-CD) now, for all that I checked. In case of Arabic,
> that'd be "ويكيبيديا (ar)".
> 
> Mind filing a new bug for that, and make that block your release bug? I'd like
> to keep the noise down on the bugs that are actually about deciding the set,
> and move the "bugs" in particular engines out to separate bug, if they're dealt
> with separately.
> 

Done. Please see bug 423433. I attached a patch to that bug.

Comment 22

[Axel Hecht [:Pike]]

I didn't find Arabic on http://wiki.mozilla.org/Firefox3_web_services_Review, so I'm asking here.

Anything for us to do for webcal and mailto protocol handler, or do we go for en-US defaults?

Comment 23

[Ayman Hourieh]

The defaults are fine.

Comment 24

[Mic Berman]

thanks, page above (in comment #22) is updated with this information

Ayman - is it worth putting in a arabic-english or some such dictionary site for one of the plug-ins? like http://dictionary.sakhr.com/ or is that covered in an available add-on somewhere?

Comment 25

[Ayman Hourieh]

I'm not familiar with this website enough to include it in the official release. Answers.com provides Arabic translations of English words so it should be enough. Let's leave it to the community to offer plugins for other websites as add-ons.

Comment 26

[Mic Berman]

thanks ayman, ok on answers i didn't know that it did that, so that's great.

Comment 27

[Axel Hecht [:Pike]]

Reopening, to match the en-US defaults for protocol handlers, we still need a patch to add yahoo mail.

Comment 28

[Ayman Hourieh]

Is it too late to use Gmail as the default for Arabic? Gmail is fully-localized in Arabic, whereas Yahoo does not appear to be.

Comment 29

[Axel Hecht [:Pike]]

Sadly gmail currently lacks the server-side support needed to include them, and they're not going to make it for 3.0. But there is a plan to get them on board later in the 3.0.x life cycle.

Comment 30

[Ayman Hourieh]

Attachment: Add Yahoo Mail as the default mailto: handler for Arabic

Comment 31

[Ayman Hourieh]

I see. I've created a patch for adding Yahoo Mail and put you as the reviewer.

Thanks.

Comment 32

[Axel Hecht [:Pike]]

Comment on attachment 314178 [details] [diff] [review]
Add Yahoo Mail as the default mailto: handler for Arabic

> gecko.handlerService.defaultHandlersVersion=0

gecko.handlerService.defaultHandlersVersion=1

> 
>-# The default set of protocol handlers for webcal
>+# The default set of protocol handlers for webcal:
> gecko.handlerService.schemes.webcal.0.name=30 Boxes
> gecko.handlerService.schemes.webcal.0.uriTemplate=http://30boxes.com/external/widget?refer=ff&url=%s
>+
>+# The default set of protocol handlers for mailto:
>+gecko.handlerService.schemes.mailto.0.name=Yahoo! Mail
>+gecko.handlerService.schemes.mailto.0.uriTemplate=http://compose.mail.yahoo.com/?To=%s
>+

r=me with the defaultHandlersVersion bumped. Please land with a check-in comment referencing this bug and my review, something like "bug 403017, adding yahoo mail to protocol handlers and bumping defaultHandlersVersion, r=[e-mail]" would work.

Thanks for the quick turnaround.

Comment 33

[Ayman Hourieh]

Hi,

I incremented the version number and committed the patch.

Thanks for your help!

Comment 34

[Axel Hecht [:Pike]]

VERIFIED, with reference http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/839cfdfa4edb/reference/HEAD/ar/.