Closed
Bug 403028
Opened 17 years ago
Closed 7 years ago
Next / Previous dialog buttons should not have > < or »
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: micmon, Assigned: ispence)
References
Details
(Keywords: polish, ue)
Attachments
(3 files)
2.94 KB,
image/png
|
Details | |
26.30 KB,
image/png
|
Details | |
1.23 KB,
patch
|
beltzner
:
review-
beltzner
:
ui-review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007110804 Minefield/3.0b2pre
The "Next" and "Previous" buttons used to be like this in FF2: "_Next >". Now, they include a GTK stock icon: "[->] _Next >". I think we should get rid of the ">" now.
Reproducible: Always
Reporter | ||
Comment 1•17 years ago
|
||
This shows the current look of the button, the example is taken from the update dialog. I think it is used somewhere else also
Updated•17 years ago
|
Summary: Next/Previous dialog buttons → Next/Previous dialog buttons have redundant ">"
Assignee | ||
Comment 2•17 years ago
|
||
Was this fixed? I'm looking at my dialogs including the update one and none have the > after Next or the < before Previous
Reporter | ||
Comment 3•17 years ago
|
||
Right now I don't see it, I will check again after tomorrow's build is out but maybe it has been fixed silently ;)
Reporter | ||
Comment 4•17 years ago
|
||
It's partly fixed I think. Next/Prev don't have the >> anymore, but "Download & Install Now" has. See screenshot.
Updated•17 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 6•17 years ago
|
||
This is a language fix, so I'm not exactly sure who to request review/superreview from. Heck, I don't even know if this patch is allowed since I believe the language freeze happened already
Assignee: nobody → ispence
Status: NEW → ASSIGNED
Comment 7•17 years ago
|
||
Comment on attachment 304573 [details] [diff] [review]
Removes the » from the update dialogs
We're not going to remove these from all platforms simply because the new Linux theme includes an image that makes them redundant.
Attachment #304573 -
Flags: ui-review-
Attachment #304573 -
Flags: review-
Comment 8•17 years ago
|
||
Looked into this a little more, and we might just want to consider removing the text-arrows from all wizard panel buttons. They're not really native to any OS that I can remember (XP, maybe?)
Comment 9•17 years ago
|
||
Now that I think about it these have slightly irked me but I never spent enough time thinking about it to realize that it's because they aren't native. I totally agree that we should remove all forms of textual arrows from all platforms.
Updated•17 years ago
|
OS: All → Linux
Comment 10•15 years ago
|
||
These entities where removed on mozilla-central and new entities and strings are now used without textual arrows
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/update/updates.properties
Fixed?
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•