403106 - pageloader needs to timeout on failure to load.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

If a page fails to load (through throwing an error, or just endlessly blocking) the pageloader will block indefinitely.  There needs to be a means of stopping the test and providing a reasonable error message if a page exceeds a given timeout.

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: add -tptimeout and -tpnoisy options to pageloader

Added support for -tptimeout and -tpnoisy.  -tptimeout allows you to set a timeout for each page loaded, if the timeout is exceeded the test is stopped.  -tpnoisy drops the name of the last loaded page to the console - this can be handy for tracking which page has caused a failure in a test.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 288770 [details] [diff] [review]
add -tptimeout and -tpnoisy options to pageloader

Just some minor stuff:

- Just have noisy always be on, no need for a separate flag.  If something is timing out, I can't imagine why we wouldn't want to know what :)

- change |var t| to be something more descriptive, like |var pageTimeoutTimer| or something; single-letter global variables are bad :)

Other than that, the patch looks fine

Comment 3

[alice nodelman [:alice] [:anode]]

Attachment: add -tptimeout and -tpnoisy options to pageloader #2

Changed to have a better name for the global variable.

I want to keep -tpnoisy separate from -tptimeout.  You will always be notified if a page timeouts, what tpnoisy does is dump the name of every page after is successfully loads.  I'd prefer to be able to nor be noisy all the time.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 288932 [details] [diff] [review]
add -tptimeout and -tpnoisy options to pageloader #2

Oh, ok; that makes sense for noisy, then.  Looks fine.

Comment 5

[alice nodelman [:alice] [:anode]]

Checking in pageloader.js;
/cvsroot/mozilla/layout/tools/pageloader/pageloader.js,v  <--  pageloader.js
new revision: 1.8; previous revision: 1.7
done
Checking in tp-cmdline.js;
/cvsroot/mozilla/layout/tools/pageloader/tp-cmdline.js,v  <--  tp-cmdline.js
new revision: 1.3; previous revision: 1.2
done

Comment 6

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.