403113 - [FIX]nsCSSFrameConstructor::ProcessPendingRestyles() doesn't need to heap allocate restylesToProcess

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Stuart Parmenter]

I'm seeing a lot of small allocations for restylesToProcess -- would be good to stack allocate them when possible.  maybe use nsAutoTArray?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Using nsAutoTArray meant either just using it to allocate and nothing else (and messing about with *Elements()) or having it update count all the time, etc.

Didn't seem worth it; this is simple enough.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think you should use nsAutoTArray. You can just call AppendElements() and use the returned pointer. It's less lines of code and safer because the destructor will get called if someone adds a new return path.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Right. Forgot about AppendElements(int)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.