403125 - Find bar highlight no longer works as expected

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007110805 Minefield/3.0b2pre ID:2007110805

1. New profile, start firefox
2. Visit http://www.mozilla.org/projects/minefield/
3. CTRL+F
4. In search box, enter: as
5. Click highlight button

Expected:
- All instances of 'as' are highlighted

Actual:
- Nothing

6. Click the highlight button again (so it is no longer in its pressed state)
7. Notice that now all instances of 'as' are highlighted.

Works as expected: 20071107_0007_firefox-3.0a9pre.en-US.win32
Strange behaviour: 20071107_0359_firefox-3.0a9pre.en-US.win32

Checkins to module PhoenixTinderbox between 2007-11-07 00:07 and 2007-11-07 03:58 :
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1194422820&maxdate=1194436739

(Note also, that the first instance of 'as' found is the last one on the page; I'm going to file on this too, since find should start from the top of the page, and I'm sure it used to)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Assuming that regression range is correct, the only changes that could have caused this are dholbert's, I think.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Sorry, I misread the bug report. Bug 282180 is more likely the cause given the part about it working if you click again.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The "Highlight All" button has: oncommand="toggleHighlight(!this.checked);". It seems to expect that the "checked" property will be toggled after the oncommand has been fired. I guess it shouldn't do that?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Indeed, that was bug 230854.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 6

[Asaf Romano (gone)]

Comment on attachment 288171 [details] [diff] [review]
patch

r=mano

Comment 7

[[e-mail]]

It just goes to show, when bug 282180 caused a problem in XPFE we fixed it. When it caused a problem in toolkit you hacked around it. Sigh.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/findbar.xml 	1.17

Comment 9

[Sanchith K]

Windows XP SP2
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre ID:2007112605

Works. Highlight All highlights all occurences of 'as' in the test page.