403134 - [FIX]"ASSERTION: Weird break found!" with -moz-column

Status: VERIFIED FIXED

(Core :: Graphics, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers

###!!! ASSERTION: Weird break found!: 'limitLength >= 0', file /Users/jruderman/trunk/mozilla/layout/generic/nsTextFrameThebes.cpp, line 5248

and content duplication.

I think this can cause hangs, too.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Jesse, are you still seeing this?  This seems to be worksforme on Linux...

Comment 2

[Jesse Ruderman]

I'm still seeing the content duplication but not the assertion.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible fix

So the problem is that when we're appending the parent frame is the second continuation of the <div>.  This does have the "have first letter" bit set, but it's not the right frame to remove the first-letter stuff from.  It needs to be removed from the first continuation.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Well, I checked in the test..  But it fails, because when we recover letter frames we don't recover the inline letter frame on continuations of the block, I guess.  Or something.  The '!' vertical position is different in the reference and the test.  I filed bug 405377 on that.

Patch itself is checked in.

So I've marked it as "fails" for now and filed bug 

Comment 5

[Boris Zbarsky [:bzbarsky]]

Should have been 'filed bug 405377'.

But I'm not sure that's the problem now...

Comment 6

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2) Gecko/2007121014 Firefox/3.0b2.  Running the testcase attached, i see no assertions nor content duplication.