403173 - Change "it's" to "it is" in Empty Cache dialog

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Samuel Sidler (old account; do not CC)]

The Empty Cache dialog reads "Camino saves the contents of web pages you visit in a cache so that it’s faster to visit them again. You cannot undo this action."

s/it's/it is

Comment 1

[Chris Lawson (gone)]

I am actually OK with the way it's worded now, but sure, whatever.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: No more "it’s" in the cache

Comment 3

[Chris Lawson (gone)]

Comment on attachment 294624 [details] [diff] [review]
No more "it’s" in the cache

r=me. This should probably be another bug, but why can't the History pref pane just use the strings from the app bundle itself, so we don't have to change stuff like this in two places?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 294624 [details] [diff] [review]
No more "it’s" in the cache

(In reply to comment #3)
> This should probably be another bug, but why can't the History pref pane
> just use the strings from the app bundle itself, so we don't have to change
> stuff like this in two places?

Because prefPanes are separate executable bundles, and they have their own strings.

Comment 5

[Mark Mentovai]

"so that it is faster to visit them again."  Really?  I don't know.

"so that they load more quickly on future visits."  Something along those lines?

We can access main bundle strings from a prefpane with:

[[NSBundle mainBundle] localizedStringForKey:key value:value tableName:nil];

or the NSLocalizedStringFromTableInBundle equivalent.

Perhaps we should add a main-bundle-string getter utility to PreferencePaneBase, or update localizedStringForKey: to fall back to checking the main bundle's strings if a string isn't present in the prefpane's own strings file.

Comment 6

[Mark Mentovai]

Another idea is to just keep a single copy of the clear-cache code, in the main executable.  Then, we can eliminate some duplicated code in addition to duplicated strings.  Right now, the main executable shows an application-modal dialog with NSRunCriticalAlertPanel, and the prefpane shows a window-modal sheet with NSBeginCriticalAlertSheet.  We can move to something where we have -[MainController runEmptyCacheDialogOnWindow:], along the lines of:

- (void)runEmptyCacheDialogOnWindow:(NSWindow*)window {
  if (window) {
    // pass emptyCacheDialogDidEnd:returnCode:contextInfo: as didEndSelector
    NSBeginCriticalAlertSheet(...);
  }
  else {
    int returnCode = NSRunCriticalAlertPanel(...);
    [self emptyCacheDialogDidEnd:nil returnCode:returnCode contextInfo:nil];
  }
}

The History prefpane's clearDiskCache: would change to a single call to [[NSApp delegate] runEmptyCacheDialogOnWindow:[self window]];.  We'd get to remove its copy of clearDiskCacheSheetDidEnd:, getting us halfway to de-Geckoizing that prefpane.  "Clear History" takes care of the other half - just repeat the above steps with that (it's the same exact thing), and History.prefPane will be completely Gecko-free.

This is an excellent exercise for anyone with any level of programming skill - it's within everyone's reach, and there's probably something interesting to learn for everyone owing to the inter-modular nature of this change.

Comment 7

[Chris Lawson (gone)]

Mark, should a new bug be filed for comment 5 and comment 6, or do we want to do that here?

Comment 8

[Mark Mentovai]

Either way, but I'm not satisfied with the wording in attachment 294624 [details] [diff] [review], so we should change the wording regardless of how much extra work you guys want to do in this bug.  :)

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Blame smfr for the wording, but yeah, I was hoping you'd say "let's make it better" ;)

Unless someone is planning on doing comment 5/comment 6 soon, I'd prefer to just fix the text here and open a new bug for the deGeckoization.

Comment 10

[Chris Lawson (gone)]

I'm on dialup or I'd have filed the bug already. Someone assign it to me and I'll get to it soon enough.

Go ahead and fix the wording here and I'll try to get the other fixed next week-ish.

cl

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Now with better text

"so that they load more quickly on future visits" sounds good to me.

See bug 410030 for the deGeckoification.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk and MOZILLA_1_8_BRANCH.