403229 - turn on talos --noisy option for mini boxes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

Attachment: turn on --noisy option

This should help up diagnose some of the failures that we are seeing on the mini boxes (I hope).

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: turn on --noisy / increase timeout on mac trunk to 6 hours

Along with --noisy we need to increase the timeout on the mac trunk boxes - we still aren't collecting any results on those machines.

Comment 2

[alice nodelman [:alice] [:anode]]

Attachment: turn on --noisy / increase timeout on mac/linux to 6 hours

Also increase timeout on linux.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 288572 [details] [diff] [review]
turn on --noisy / increase timeout on mac/linux to 6 hours

I think you forgot to set the patch flag on this. Could you resubmit it so I can view it please?

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 288572 [details] [diff] [review]
turn on --noisy / increase timeout on mac/linux to 6 hours

Setting patch flag.

Comment 5

[alice nodelman [:alice] [:anode]]

Attachment: fix for command processing in perfrunner.py

Turning on --noisy ended up finding us a bug in the perfrunner.py where the command line was being appended to each run, ending up with huge command line with many, many config file names at the end.  

This patch should stop the madness.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 288783 [details] [diff] [review]
fix for command processing in perfrunner.py

just checked this in a shell and it's still not going to work. append() modifies in place without returning so self.command would end up being None. to set self.command = copy.deepcopy(self.command) first, then self.command.append as in the original version.

Comment 7

[alice nodelman [:alice] [:anode]]

Attachment: fix for command processing in perfrunner.py #2

Previous patch wasn't using copy.deepcopy correctly.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 288785 [details] [diff] [review]
fix for command processing in perfrunner.py #2

it's so crazy it just might work!

Comment 9

[alice nodelman [:alice] [:anode]]

Checking in perfrunner.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/perfrunner.py,v  <--  perfrunner.py
new revision: 1.7; previous revision: 1.6
done

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: fix for perfrunner using shallow copy instead of deepcopy

turns out the deepcopy's overkill.

Comment 11

[Rob Campbell [:rc] (:robcee)]

Checking in perfrunner.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/perfrunner.py,v  <--  perfrunner.py
new revision: 1.8; previous revision: 1.7
done

Comment 12

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.