Closed
Bug 403249
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute
Categories
(Core :: Layout: Tables, defect, P2)
Core
Layout: Tables
Tracking
()
VERIFIED
FIXED
mozilla1.9beta2
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
|
307 bytes,
text/html
|
Details | |
|
9.37 KB,
patch
|
bernd_mozilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
3.13 KB,
patch
|
Details | Diff | Splinter Review |
Loading the testcase triggers: ###!!! ASSERTION: How did that happen??: 'col->GetStyleContext() == colFrame->GetStyleContext() && col->GetContent() == colFrame->GetContent()', file /Users/jruderman/trunk/mozilla/layout/tables/nsTableColGroupFrame.cpp, line 326 This assertion was added recently, in bug 399209.
|
Assignee | |
Comment 1•17 years ago
|
||
Good thing I added that assert! The frame model depends on the span attribute, but changing that attribute only triggered a reflow. Not good. The other change in this patch is to make the span style prop never be 0 or negative. Not sure whether that's correct; do we support span="0" in some way different from span="1"?
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #288234 -
Flags: superreview?(roc)
Attachment #288234 -
Flags: review?(bernd_mozilla)
|
|
Assignee | |
Comment 2•17 years ago
|
||
We should get this fixed. Having the frame tree not match what we expect is very bad.
Severity: normal → major
Flags: blocking1.9?
OS: Mac OS X → All
Hardware: PC → All
Summary: "ASSERTION: How did that happen??" with <col>, changing "span" attribute → [FIX]"ASSERTION: How did that happen??" with <col>, changing "span" attribute
Target Milestone: --- → mozilla1.9 M10
Attachment #288234 -
Flags: superreview?(roc) → superreview+
|
||
Comment 3•17 years ago
|
||
Plusing based on comment 2
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
>do we support span="0" in some way different from span="1"?
There is no reason for this the HTML 4.01 spec says clearly:
"
span = number [CN]
This attribute, whose value must be an integer > 0,....
"
Attachment #288234 -
Flags: review?(bernd_mozilla) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checked in. We should get the test in once we have a place for assertion tests...
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•17 years ago
|
||
|
|
Assignee | |
Comment 7•17 years ago
|
||
Comment on attachment 289279 [details] [diff] [review] Some correctness tests (checked in; still need assertion test) Checked in the correctness tests. Still need to do the assertion test.
Attachment #289279 -
Attachment description: Some correctness tests (still need assertion test) → Some correctness tests (checked in; still need assertion test)
|
|
Assignee | |
Comment 8•17 years ago
|
||
Added a visibility:collapse test too.
|
||
Comment 9•17 years ago
|
||
verified fixed using debug build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120520 Minefield/3.0b2pre - no assertion on testcase -> Verified
Status: RESOLVED → VERIFIED
|
Reporter | |
Comment 10•17 years ago
|
||
I checked in my original testcase as a crashtest. (bz, I assume that's what you wanted.)
Flags: in-testsuite? → in-testsuite+
|
|
Assignee | |
Comment 11•17 years ago
|
||
Yes, that sounds great.
You need to log in
before you can comment on or make changes to this bug.
Description
•