403266 - usechromesheets attribute does not work if there is no userContent.css in the profile

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[John J Foerch]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070505 (Debian-1.8.0.14~pre071019b-0etch1)
Build Identifier: Mozilla XULRunner 1.8.0.13pre_0000000000

Developing a XULRunner program, with a xul:browser element with the attribute `usechromesheets' to load a particular style sheet.  I found that the style sheet does not work when I have no chome/userContent.css in my profile directory.  However, all I have to do is `touch userContent.css' in my profile chrome directory, and suddenly the sheet given in usechromesheets gets loaded and works properly.

This bug was obvserved by me with XULRunner 1.8.0.13pre_0000000000 and by someone else with XULRunner 1.8.1.3_2007050720.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This happen because the wrong variable is checked somewhere in the code.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch check csssheet instead of sheet which is not relevant in our case.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 441995 [details] [diff] [review]
Patch

r=dbaron

Do you need somebody to land this for you?

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

An automated test for this would be nice, but it might be hard.  (Then again, we probably don't have any automated tests for usechromesheets at all, and that might be somewhat easier.)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> (From update of attachment 441995 [details] [diff] [review])
> r=dbaron
> 
> Do you need somebody to land this for you?

Yep, please.

(In reply to comment #4)
> An automated test for this would be nice, but it might be hard.  (Then again,
> we probably don't have any automated tests for usechromesheets at all, and that
> might be somewhat easier.)

I wondering if we could not just do something like:
 * check for the element.style.something
 * add the usechromesheets attribute dynamically to a browser/iframe/anything else
 * check again the element.style.something

This will not check the userContent.css/userChrome.css specific case but at least this will check usechromesheets to see if it's working.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/972ec16052aa

marking in-testsuite? for the above discussion.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #5)
> I wondering if we could not just do something like:
>  * check for the element.style.something
>  * add the usechromesheets attribute dynamically to a browser/iframe/anything
> else
>  * check again the element.style.something
> 
> This will not check the userContent.css/userChrome.css specific case but at
> least this will check usechromesheets to see if it's working.

Yes, that would be a good test for usechromesheets (assuming that it applies dynamically).