403273 - Sparkle doesn't build for 10.3

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Attachment: fix

There are several issues in the Sparkle tree that prevent building with gcc3.3/10.3.9SDK. This patch will work around them all locally; since we don't plan to sync the branch's pull of Sparkle again unless we have a pressing need, mini-forking the branch seems like an acceptable solution to me.

The localizedFailureReason workaround is totally a punt here. I have no idea what the right solution here should be for 10.3 (have a localized string, perhaps, but that's not something I think we want to take on), but this seemed better than throwing an exception and crapping out. Suggestions welcome.

Chris was going to look into getting this (or the equivalent) pushed upstream, so that if for some reason we do need to we can just blow away our local changes. I can add a comment to the readme referencing this bug at checkin, unless there's a better way to document our changes.

Comment 1

[Mark Mentovai]

Comment on attachment 288076 [details] [diff] [review]
fix

Let's tag the current state of Sparkle, too.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I tested this (not every single permutation, though), and it does seem to work just fine on 10.3.9.  Autoconf-2.13 is fun! Uni builds are nifty! Automated updates rock!

Comment 3

[Stuart Morgan]

Branch sparkle subtree tagged as CAMINO_SPARKLE_R52, and patch landed on MOZILLA_1_8_BRANCH.