Closed
Bug 403280
Opened 18 years ago
Closed 18 years ago
nsLayoutUtils::DoCompareTreePosition and nsContentUtils::ComparePoints should use nsAutoTArray
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: pavlov, Assigned: pavlov)
Details
(Keywords: memory-footprint, perf)
Attachments
(1 file)
|
3.60 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
nsAutoVoidArray only uses 8 buckets which causes lots and lots and lots of allocations when going through this code for no reason. Let us increase that number.
also changing nsContentUtils::ComparePosition to 32 per jonas
Attachment #288092 -
Flags: review?(jonas)
Attachment #288092 -
Flags: superreview+
Attachment #288092 -
Flags: review?(jonas)
Attachment #288092 -
Flags: review+
Attachment #288092 -
Flags: approval1.9+
|
Assignee | |
Comment 1•18 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 2•18 years ago
|
||
Why not use nsAutoTPtrArray throughout?
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•