403296 - "WARNING: Expected surface of type Quartz, got something else"

Status: RESOLVED FIXED

(Core :: Graphics, defect, P4)

Description

[Jesse Ruderman]

Attachment: testcase

Steps to reproduce:
1. Load the testcase (locally is best)
2. Let the testcase reload itself for a while.

Result:

WARNING: Expected surface of type Quartz, got somthing else: file /Users/jruderman/trunk/mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm, line 602

Comment 1

[Josh Aas]

Marking this blocking? until I can investigate, that warning can be a sign of bad things.

Comment 2

[Mike Schroepfer]

Plusing with p5 - if anyone here thinks different let me know..

Comment 3

[Josh Aas]

Attachment: stack trace 1

Here is the stack from when we get an unexpected surface type.

Comment 4

[Josh Aas]

When DrawWidgetBackground is called with an unexpected surface type, the widget it is being asked to draw has a type value of 12, which is NS_THEME_TOOLBAR.

Comment 5

[Josh Aas]

Over to gfx:thebes, this doesn't look like a Cocoa widget issue. The widget native theme code shouldn't be given a surface that is not a Quartz surface.

Comment 6

[Josh Aas]

I checked in a fix for the spelling of "somthing" in the error message.

Comment 7

[Stuart Parmenter]

does this actually break anything?

Comment 8

[Josh Aas]

Not that we know of, you might want to watch the test case closely yourself.

Comment 9

[Stuart Parmenter]

I'll take a look at it, but if it isn't breaking anything fixing a warning doesn't seem like it should block.  Moving to ? until I can see whats going on.

Comment 10

[Stuart Parmenter]

vlad: you taking a look at this?

Comment 11

[Mike Schroepfer]

Ping on this - been sitting in the nom queue for over a week.  Vlad/Pav anything you want to do with this?

Comment 12

[Stuart Parmenter]

someone was hitting this earlier in another part of our code... will + for now low priority

Comment 13

[Mike Schroepfer]

Moving off blocking list .  Pav reset if you disagree..

Comment 14

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It will be fixed by the marked dep bug.

Comment 15

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: clean up last warning patch

We'll need this as well; nothing harmful is happening at this point, but we should shut up this error.

Comment 16

[Jesse Ruderman]

Crashtest checked in, even though this was a warning rather than an assertion.