403576 - [FIX]"ASSERTION: Margins on anonymous fieldset child not supported!" with <fieldset style="display: table-column-group;">

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: Bogus availSize.width; should be bigger: '!mContentFrame || GetContentMinWidth(aReflowState.rendContext) <= availSize.width', file /Users/jruderman/trunk/mozilla/layout/forms/nsFieldSetFrame.cpp, line 470

###!!! ASSERTION: width less than zero: 'aContainingBlockWidth >= 0', file /Users/jruderman/trunk/mozilla/layout/base/nsLayoutUtils.cpp, line 1643

###!!! ASSERTION: Margins on anonymous fieldset child not supported!: 'kidReflowState.mComputedMargin == nsMargin(0,0,0,0)', file /Users/jruderman/trunk/mozilla/layout/forms/nsFieldSetFrame.cpp, line 556

The last assertion was added by roc in bug 336153, a few days ago.

This bug might be related to bug 402850.

Comment 1

[Boris Zbarsky [:bzbarsky]]

(gdb) p kidReflowState.mComputedMargin
$1 = {top = 0, right = -828, bottom = 0, left = 0}
(gdb) p aReflowState.mComputedWidth
$3 = -828

I call bogus right about then!

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 288453 [details] [diff] [review]
Fix

r+sr=dbaron.  Sorry for the long delay here.

(Worth approving; it's just a test to make sure a width doesn't go below zero, plus a bunch of assertions.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 288453 [details] [diff] [review]
Fix

This is just adding some basic safety checks.  This should be very safe.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 288453 [details] [diff] [review]
Fix

a=beltzner for 1.9

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.  I checked in the crashtest too.