Closed Bug 403616 Opened 17 years ago Closed 13 years ago

--enable-application=standalone is no longer supported

Categories

(Firefox Build System :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: benjamin, Assigned: matjk7)

Details

(Keywords: dev-doc-complete, Whiteboard: fixed-in-bs)

Attachments

(1 file)

The --enable-application=standalone option no longer works (since bug 380846) and I believe we should remove it instead of trying to fix it. If somebody wants to resurrect standalone xpconnect they can create a build.mk file for it in js/src/xpconnect
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Attachment #555272 - Flags: review?(ted.mielczarek)
Comment on attachment 555272 [details] [diff] [review] patch >-#if !defined(XPCONNECT_STANDALONE) >- I'll game the system with my r+ if you also remove the DEFINE from config.mk for that. (and the ifeq around it) no-one else uses this define.
Attachment #555272 - Flags: review?(ted.mielczarek) → review+
(In reply to Justin Wood (:Callek) from comment #2) > Comment on attachment 555272 [details] [diff] [review] > patch > > > >-#if !defined(XPCONNECT_STANDALONE) > >- > > I'll game the system with my r+ if you also remove the DEFINE from config.mk > for that. (and the ifeq around it) no-one else uses this define. That code is only on comm-central and this patch is for mozilla-central.
(In reply to Matheus Kerschbaum from comment #3) > (In reply to Justin Wood (:Callek) from comment #2) > > Comment on attachment 555272 [details] [diff] [review] > > patch > > > > > > >-#if !defined(XPCONNECT_STANDALONE) > > >- > > > > I'll game the system with my r+ if you also remove the DEFINE from config.mk > > for that. (and the ifeq around it) no-one else uses this define. > > That code is only on comm-central and this patch is for mozilla-central. O whops yes, read too fast and thought that config.mk was mozilla/*/config.mk well, r+ still stands, and I'll add an rs+ for the c-c config.mk while you're at it, if you want.
Keywords: checkin-needed
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-bs
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
The only place building standalone XPConnect was even mentioned was on this page: https://developer.mozilla.org/En/Developer_Guide/Build_Instructions It no longer mentions it. The actual --enable-application=standalone option was never mentioned anywhere on MDN.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: