--enable-application=standalone is no longer supported

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
--
minor
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: bsmedberg, Assigned: Matheus Kerschbaum)

Tracking

({dev-doc-complete})

Trunk
mozilla9
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
The --enable-application=standalone option no longer works (since bug 380846) and I believe we should remove it instead of trying to fix it. If somebody wants to resurrect standalone xpconnect they can create a build.mk file for it in js/src/xpconnect
(Assignee)

Updated

6 years ago
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 555272 [details] [diff] [review]
patch
Attachment #555272 - Flags: review?(ted.mielczarek)
Comment on attachment 555272 [details] [diff] [review]
patch


>-#if !defined(XPCONNECT_STANDALONE)
>-

I'll game the system with my r+ if you also remove the DEFINE from config.mk for that. (and the ifeq around it) no-one else uses this define.
Attachment #555272 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Justin Wood (:Callek) from comment #2)
> Comment on attachment 555272 [details] [diff] [review]
> patch
> 
> 
> >-#if !defined(XPCONNECT_STANDALONE)
> >-
> 
> I'll game the system with my r+ if you also remove the DEFINE from config.mk
> for that. (and the ifeq around it) no-one else uses this define.

That code is only on comm-central and this patch is for mozilla-central.
(In reply to Matheus Kerschbaum from comment #3)
> (In reply to Justin Wood (:Callek) from comment #2)
> > Comment on attachment 555272 [details] [diff] [review]
> > patch
> > 
> > 
> > >-#if !defined(XPCONNECT_STANDALONE)
> > >-
> > 
> > I'll game the system with my r+ if you also remove the DEFINE from config.mk
> > for that. (and the ifeq around it) no-one else uses this define.
> 
> That code is only on comm-central and this patch is for mozilla-central.

O whops yes, read too fast and thought that config.mk was mozilla/*/config.mk

well, r+ still stands, and I'll add an rs+ for the c-c config.mk while you're at it, if you want.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/projects/build-system/rev/443d9a9d3c67
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-bs
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/443d9a9d3c67
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
The only place building standalone XPConnect was even mentioned was on this page:

https://developer.mozilla.org/En/Developer_Guide/Build_Instructions

It no longer mentions it.

The actual --enable-application=standalone option was never mentioned anywhere on MDN.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.