403641 - hitting escape doesn't save changes to the bookmark title [was: Dismissing the Bookmark pop-up without bookmarking - JS Console error]

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111309 Minefield/3.0b2pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111309 Minefield/3.0b2pre Firefox/3.0

Using Bookmark this page with Ctrl+D, or from the right-click context menu, and then deciding you don't want to bookmark, and click outside the dialog box is showing an error in JS console2:

Error: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getItemTitle]
Source file: chrome://browser/content/places/editBookmarkOverlay.js
Line: 297



Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
Error in Error Console2

Expected Results:  
No errors


Latest hourly build on Vista HP

Most likely due to checkin of: 
https://bugzilla.mozilla.org/show_bug.cgi?id=398409

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Might be a seperate issue, but I also note that a bookmark is created even
though you click outside the dialog box.  

Looking at the Bookmarks drop list from the Menu-bar and finding the bookmark,
right-click and delete the bookmark.  

I see in console2:

The one appears twice:
Error: this.selectedNode.parent is null
Source file: chrome://browser/content/places/menu.xml
Line: 463

Error: '[JavaScript Error: "this.selectedNode.parent is null" {file:
"chrome://browser/content/places/menu.xml" line: 463}]' when calling method:
[nsIController::isCommandEnabled] = NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS
Source file: chrome://browser/content/places/controller.js
Line: 1644 

Comment 2

[Florian Quèze [:florian]]

(In reply to comment #0)
> Error: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE)
> [nsINavBookmarksService.getItemTitle]
> Source file: chrome://browser/content/places/editBookmarkOverlay.js
> Line: 297

> 
> Most likely due to checkin of: 
> https://bugzilla.mozilla.org/show_bug.cgi?id=398409
> 

This error was already there before.

Mano, do you know if there was already a bug # for this error when closing the bookmark popup? I couldn't find it.

(In reply to comment #1)
> Might be a seperate issue, but I also note that a bookmark is created even
> though you click outside the dialog box.

See bug 396513 for a related issue.

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v1

So the problem here is that onblur on the title field is fired after onpopuphiding on the bookmark popup. Moving the uninitialization of the panel to the popuphidden event fixes the bug.

Comment 5

[(not reading, please use [e-mail] instead)]

morphing bug

steps:

1)  go to google.com
2)  click the star button, twice, first to bookmark, second to edit
3)  change the title, but before you do anything else, while the title text box still has focus, hit escape

the panel will close, but the title will not change.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 288580 [details] [diff] [review]
patch v1

r=mano

Comment 7

[Reed Loden [:reed]]

Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.64; previous revision: 1.63
done

Comment 8

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv