403694 - "File -> Work Offline" leaks nsDNSService

Status: RESOLVED DUPLICATE of bug 419562

(Core :: Networking, defect, P4)

Description

[Carsten Book [:Tomcat]]

Steps to reproduce:
Start Firefox
Go into offline mode
Leaked!

nsStringStats
 => mAllocCount:          20426
 => mReallocCount:         3165
 => mFreeCount:           20401  --  LEAKED 25 !!!
 => mShareCount:          17591
 => mAdoptCount:           2523
 => mAdoptFreeCount:       2520  --  LEAKED 3 !!!

Will attach leak log

Comment 1

[Carsten Book [:Tomcat]]

Attachment: Leak Log

Comment 2

[Jesse Ruderman]

The leak log looks similar to what I see in bug 102229.  If you have found a consistent way to reproduce bug 102229, you have won.

Comment 3

[Carsten Book [:Tomcat]]

Attachment: log from today

jesse, i can reproduce this leak. I have tested the steps to reproduce again and still leak and the log looks like the same as yesterday

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Not sure which way to do the blocking.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Affects tomcats testing so marking a blocker.

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1

When we go into offline mode nsIOService::SetOffline calls nsSocketTransportService::Shutdown, which will shut down the socket thread. Later, when quitting, we end up calling nsHttpConnectionMgr::Shutdown, which does PostEvent(&nsHttpConnectionMgr::OnMsgShutdown) to do its cleanup. PostEvent tries and fails to post an event to the socket thread and so we skip cleanup.

Comment 7

[Martijn Wargers (dead)]

Attachment: testcase (uses enhanced privs)

I don't know if a testcase is still necessary, but this reproduce the leak for me, consistently.
The testcase uses enhanced privileges, so you need to download it to your computer.

Comment 8

[Carsten Book [:Tomcat]]

peter, do you know if the patch from comment #6 is ready to go ? 

Comment 9

[Peter Van der Beken [:peterv]]

I'm still tracking down an issue with it.

Comment 10

[Peter Van der Beken [:peterv]]

Bent has a better patch in bug 419562.