Closed
Bug 403733
Opened 17 years ago
Closed 17 years ago
[FIX]<legend> changed from display:none is shown inside the fieldset rather than on its border
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: regression, testcase)
Attachments
(3 files)
|
240 bytes,
text/html
|
Details | |
|
154 bytes,
text/html
|
Details | |
|
2.82 KB,
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
The testcase and reference have the same final DOM, so they should display the same way. They are based on layout/reftests/bugs/359869-1.html (from bug 359869).
Could this be a regression from bug 336153?
|
Reporter | |
Comment 1•17 years ago
|
||
|
|
Reporter | |
Comment 2•17 years ago
|
||
|
Assignee | |
Comment 3•17 years ago
|
||
More likely bug 386642.
|
|
Assignee | |
Comment 4•17 years ago
|
||
Yeah, definitely. The problem is that the parent is not the fieldset but rather its insertion frame, so the test for parent type in IsValidSibling() fails.
Blocks: 386642
|
|
Assignee | |
Comment 5•17 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #288691 -
Flags: superreview?(roc)
Attachment #288691 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
Keywords: regression
Summary: <legend> changed from display:none is shown inside the fieldset rather than on its border → [FIX]<legend> changed from display:none is shown inside the fieldset rather than on its border
Attachment #288691 -
Flags: superreview?(roc)
Attachment #288691 -
Flags: superreview+
Attachment #288691 -
Flags: review?(roc)
Attachment #288691 -
Flags: review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 288691 [details] [diff] [review]
Proposed fix
reasonably safe regression fix
Attachment #288691 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #288691 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 7•17 years ago
|
||
Checked in, including the tests. Jesse, thanks for the test pair!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•