403794 - Crashes and unit'd aExtraState in various ::GetState() impls

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

We used to return an error for nsAccessible::GetState() when an object had been shut down. We don't do that anymore, but we forgot to add new checks mDOMNode in the various GetState() methods. This can cause crashes.

Comment 1

[Aaron Leventhal]

Attachment: GetState() cleanup

Comment 2

[Aaron Leventhal]

Attachment: GetState() cleanup

Also, we most classes don't need to do anything special for STATE_FOCUSABLE anymore since nsAccessible impl does that with frame->IsFocusable() now.

Comment 3

[Aaron Leventhal]

Marco, if you have time to try running with this patch that'd be great.

Comment 4

[Aaron Leventhal]

Marco, if you have time to try running with this patch that'd be great.

Comment 5

[alexander :surkov (:asurkov)]

1. nsXULToolbarSeparatorAccessible::GetState

+*aExtraState = mDOMNode ? nsIAccessibleStates::EXT_STATE_DEFUNCT : 0;.

Get back check on aExtraState.


2. nsXULListitemAccessible::GetState(

if (mIsCheckbox) {
  return nsXULMenuitemAccessible::GetState(aState, aExtraState);

Up this line otherwise you will set EXT_STATE_DEFUNCT twice

the rest looks ok

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 288713 [details] [diff] [review]
GetState() cleanup

r=me with comment above

Comment 7

[Aaron Leventhal]

Comment on attachment 288713 [details] [diff] [review]
GetState() cleanup

Will address Surkov's comments at checkin.