40382 - mousedown on dropdown listbox, mouseup in dropdown --> no onclick

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jesse Ruderman]

the dropdown window for dropdown listboxes is eating click events.

(url is an attachment on bug 40003)

Comment 1

[Jesse Ruderman]

the same dropdown window also failing to bubble onmouseup to its container in
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=8919 (attachment to 
bug 39985).  is that a separate bug?

Comment 2

[rods (gone)]

The porblem is: when you click on on the select and up on an option the left 
down content won't match the left up content and the click count is being set to 
zero and then onclick event is never set.

Here is the where the badness is happening nsEventStateManager.cpp line #1636, 
the if statment below fails and zero the click count, this is bad.

  case NS_MOUSE_LEFT_BUTTON_UP:
    if (mLastLeftMouseDownContent == mouseContent.get()) {
      aEvent->clickCount = mLClickCount;
      mLClickCount = 0;
    }
    else {
      aEvent->clickCount = 0;
    }
    NS_IF_RELEASE(mLastLeftMouseDownContent);
    break;

Comment 3

[rods (gone)]

I forgot to mention that on line 3600 of widget/src/windows/nsWindow.cpp I had 
to add the following line so mouse up events have a click count of "1" 
    event.clickCount = 1;

Comment 4

[rods (gone)]

I am also wondering if instead of comparing the click down content directly with 
the click up content, there was someway to tell if it was ok that you clicked 
down on the parent and up on the child. Although I think the select/option 
relationship is the only parent/child relationship where this is ok.

Comment 5

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 6

[rods (gone)]

taking this back

Comment 7

[rods (gone)]

*** Bug 40003 has been marked as a duplicate of this bug. ***

Comment 8

[rods (gone)]

Talked with joki we are going to set the clickCount appropriately, its a little 
hacky bu really the only solution at this time.

Comment 9

[rods (gone)]

fixed

Comment 10

[Prashant Desale]

Verified with 2000-06-01-09.

Comment 11

[rods (gone)]

Reopening, my fix stops onclick event being generated when you click down on the 
combobox. I have a better fix now (low risk)

Comment 12

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 13

[rods (gone)]

fixed

Comment 14

[Prashant Desale]

Verified with 2000-07-07-10.