403847 - places organizer search won't find items tagged with multi-word tags

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

places organizer search won't find items tagged with multi-word tags

the problem is we call URIHasTag() with each term

http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#4414

but ParseSearchTermsFromQuery will break apart multi-word tags
(see http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#5146)

one solution could be to move the URIHasTag out of that for loop, and then use the tokenized words to build up the possible consecutive tags, and use URIHasTag() for each possible tag.  (see bug #395452 for how that works.)

doing that would fix this bug and fix bug #395462

Comment 1

[(not reading, please use [e-mail] instead)]

yes, the fix is to move out the tag check from that loop, until afterwards.

using each token, then figure out all the possible consecutive tags, and call URIHasTag() for each one of those.

got this working locally, as part of bug #395462

Comment 2

[(not reading, please use [e-mail] instead)]

fixed as part of bug #405235

Comment 3

[Reed Loden [:reed]]

You mean bug 395452, I hope.

Comment 4

[(not reading, please use [e-mail] instead)]

> You mean bug 395452, I hope.

ugh, I did.  thanks reed.

Comment 5

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112804 Minefield/3.0b2pre

Comment 6

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7505 added to litmus on 3.1 test run for regression testing.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv