Closed Bug 403857 Opened 14 years ago Closed 12 years ago

Windows file picking codepath in Applications preference pane should use isValidHandlerApp

Categories

(Firefox :: Preferences, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: Gavin, Assigned: jimm)

Details

Attachments

(1 file)

Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
Assignee: nobody → jmathies
Simple code touch up from a patch that landed last year. (doing some bug list maintenance)
Attachment #371489 - Flags: review?(myk)
Comment on attachment 371489 [details] [diff] [review]
handler touchup patch v.1

Urk, sorry, I just noticed this again.  Somehow it disappeared from my list of things to do.

This looks just right.  r=myk

Note: I try to get to reviews within a business day of them being requested. If it's been a few days, and I haven't responded, then it might have fallen on the ground, so please ping me again!
Attachment #371489 - Flags: review?(myk) → review+
http://hg.mozilla.org/mozilla-central/rev/524d3e50cdbc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Windows file picking codepath in Applications preference pane should use _isValidHandlerExecutable → Windows file picking codepath in Applications preference pane should use isValidHandlerApp
Target Milestone: --- → Firefox 3.7a1
You need to log in before you can comment on or make changes to this bug.