403862 - DOMWindow leak involving nzherald.co.nz

Status: RESOLVED INCOMPLETE

(Core :: DOM: Navigation, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I had a long (multi-day) session on very recent trunk (post beta 1) and had a DOMWindow leak when I shut it down. No steps to reproduce, sorry. Here's the leak-gauge output:

Leaked inner window 3e4bcba0 (outer 3c2d5f70) at address 3e4bcba0.
 ... with URI "https://sec.westpac.co.nz/IOLB/csReq?&dse_applicationId=-1&dse_pageId=2&dse_processorId=AMITGOASBPFFGNAWHIBRHVDXAGGNJMHVDEGLFSIS&dse_operationName=LogonProc&dse_processorState=welcomeRedirectPageState&dse_nextEventName=welcome".
Leaked inner window 44376dc0 (outer 3c2d5f70) at address 44376dc0.
 ... with URI "http://www.nzherald.co.nz/section/4/story.cfm?c_id=4&objectid=10476155".
Leaked outer window 3c2d5f70 at address 3c2d5f70.
Leaked inner window 42d8f7e0 (outer 3c2d5f70) at address 42d8f7e0.
 ... with URI "http://www.nzherald.co.nz/".
Leaked inner window 3600b230 (outer 362ec4b0) at address 3600b230.
 ... with URI "chrome://browser/content/hiddenWindow.xul".
Leaked inner window 3eec6600 (outer 3c2d5f70) at address 3eec6600.
 ... with URI "http://www.nzherald.co.nz/section/1/story.cfm?c_id=1&objectid=10476194".
Leaked outer window 362ec4b0 at address 362ec4b0.
Leaked document at address 3b373c00.
 ... with URI "http://www.nzherald.co.nz/section/1/story.cfm?c_id=1&objectid=10476194".
Leaked docshell at address 4454e7a0.
 ... which loaded URI "https://sec.westpac.co.nz/IOLB/csReq?&dse_applicationId=-1&dse_pageId=2&dse_processorId=AMITGOASBPFFGNAWHIBRHVDXAGGNJMHVDEGLFSIS&dse_operationName=LogonProc&dse_processorState=welcomeRedirectPageState&dse_nextEventName=welcome".
 ... which loaded URI "about:blank".
 ... which loaded URI "http://www.nzherald.co.nz/section/4/story.cfm?c_id=4&objectid=10476155".
 ... which loaded URI "http://westpac.co.nz/homepage.html".
 ... which loaded URI "https://sec.westpac.co.nz/IOLB/csReq".
 ... which loaded URI "http://www.nzherald.co.nz/section/story.cfm?c_id=5&objectid=10476203".
 ... which loaded URI "http://www.nzherald.co.nz/section/1/story.cfm?c_id=1&objectid=10476193".
 ... which loaded URI "https://sec.westpac.co.nz/IOLB/newSession".
 ... which loaded URI "http://www.nzherald.co.nz/section/story.cfm?c_id=1&objectid=10476194".
 ... which loaded URI "http://westpac.co.nz/".
 ... which loaded URI "http://www.nzherald.co.nz/section/story.cfm?c_id=4&objectid=10476155".
 ... which loaded URI "http://www.nzherald.co.nz/section/1/story.cfm?c_id=1&objectid=10476194".
 ... which loaded URI "https://intranet.mozilla.org/forum/comments.php?DiscussionID=237&page=1#Item_5".
 ... which loaded URI "http://www.nzherald.co.nz/".
 ... which loaded URI "https://intranet.mozilla.org/forum/".
Summary:
Leaked 7 out of 3636 DOM Windows
Leaked 1 out of 7958 documents
Leaked 1 out of 1546 docshells

Comment 1

[Jesse Ruderman]

Does loading any of these URLs cause the leak to happen again?  Or, can you remember what you did on http://www.nzherald.co.nz/section/1/story.cfm?c_id=1&objectid=10476194 ?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Reloading those URLs, I can't reproduce the leak. I don't think I did anything special on the nzherald URLs other than read them.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I've seen similar things where I leak a window here and there for pages I was interacting with, but then the leak wasn't reproducable later.  It would probably be good to figure out why this kind of thing happens, although I'm not sure if there's enough in this bug to go on...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think there's enough here to go on, either.

The only thing I can think of is to ramp up automated tools that not only load random pages but also interact with them, in ways that can be reproduced later.

Comment 5

[Jesse Ruderman]

What types of interaction on web pages are likely to cause leaks?  sayrer is already loading random web pages and watching for leaks (see http://wiki.mozilla.org/LeakingPages).  I'm already doing DOM fuzzing on random pages and watching for leaks.  I think Martijn sends random events to web pages, but I don't know whether he watches for leaks.

Other ideas:

* Record your own interactions (clicks and mouse moves and key presses), and play them back if you hit leaks and can't remember exactly what you did on the page.

* Run under your valgrind-based record-everything debugger, if you can get it to be fast enough.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Actually, the best way to do that is to use VMWare's record and reply support. Anyone game to try it? I think Fusion doesn't support it yet unfortunately so unless you want to try running VMWare in a VM, someone with Linux or Windows will need to do this.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: another DOMWindow leak

After another multi-day session, I leaked again; here's the leak-gauge output. The thing it has in common with the last one is nzherald.co.nz. That site uses Flash quite a bit.