404015 - The Password Manager dialog's list selection changes when pressing Escape

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P4)

Description

[(no longer active)]

Steps to reproduce:

1. Open Password Manager.  Initially, the passwords list has no selection.
2. Press Escape.  The first item in the list gets selected.
3. Press Escape again.  The selection disappears.
4. Continuing to press Escape toggles the selection state of the passwords list.

This happens because the code in <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/passwordmgr/content/passwordManager.js&rev=1.18&mark=310-313#310> does not check if the search box is empty before calling |SignonClearFilter|.  The fix should be simple: call |SignonClearFilter| only if the pressed key is the Escape key and the search box is not empty.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Trivial patch to fix the problem.

Comment 2

[(no longer active)]

Comment on attachment 292330 [details] [diff] [review]
Patch (v1)

Asking mano to review...

Comment 3

[Asaf Romano (gone)]

Comment on attachment 292330 [details] [diff] [review]
Patch (v1)

r=mano

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/components/passwordmgr/content/passwordManager.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/content/passwordManager.js,v  <--  passwordManager.js
new revision: 1.23; previous revision: 1.22
done