The copy of verify-locales on build-console is kinda troubled - its rev 184.108.40.206 when the tip is rev 1.5 - the output it produces is bogus (see attachment) - complains about missing en-US.xpi - complains about adt, browser, talkback, xpcom xpi's - complains that all the mac dmg's are missing
Priority: -- → P2
Summary: verify-locales gives bogus output → Bootstrap::Stage - verify-locales gives bogus output
This addresses the problems above by (respectively) - removing en-US from the copy of the locale list when checking the xpi dirs - inverted the sense of the check - fixing the regexp It also fixes the return status' so they trickle back up properly, and provides a PASS line if everything tests ok.
Attachment #289019 - Flags: review?(rhelmer)
Attachment #289019 - Flags: review?(rhelmer) → review+
Checking in verify-locales.pl; /mofo/release/stage/verify-locales.pl,v <-- verify-locales.pl new revision: 1.6; previous revision: 1.5 done Also updated the checkout on stage (which was on a sticky tag of rev1.1). Tried it with 3.0b1 and it reported problems for linux (where the suffix changed to .tar.bz2), but strangely passed Mac & Win32 with their "Beta 1" strings. Any objections to updating the checkout on build-console to pull from cvs.m.o rather than the the local mirror ? (That's a remnant from a clone from a staging setup ?)
(In reply to comment #2) > Any objections to updating the checkout on build-console to pull from cvs.m.o > rather than the the local mirror ? (That's a remnant from a clone from a > staging setup ?) Go for it.. we should move this out of /mofo (maybe directly into bootstrap?) but not in this bug I guess :)
> Go for it.. we should move this out of /mofo (maybe directly into bootstrap?) > but not in this bug I guess :) Done, no changes except those in this bug. Would indeed be great to pull this into Bootstrap. There's a whole bunch of duplicated/very-similar-looking regexp's from the groom-files anyway.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.