Closed
Bug 404184
Opened 17 years ago
Closed 17 years ago
Cmd+Opt+Arrow next/previous tab shortcut is broken
Categories
(Toolkit :: UI Widgets, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.9beta2
People
(Reporter: dietrich, Assigned: Gavin)
References
Details
(Keywords: regression)
Attachments
(1 file)
2.11 KB,
patch
|
asaf
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8) Gecko/2007091211 GranParadiso/3.0a8
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8) Gecko/2007091211 GranParadiso/3.0a8
cmd+opt+{left/right arrow} no longer works in nightlies.
Reproducible: Always
Steps to Reproduce:
1. with more than 1 tab open, hit cmd+opt+arrow
Actual Results:
nothing happens
Expected Results:
next or previous tab is selected
Reporter | ||
Comment 1•17 years ago
|
||
Note: I tried this with a new profile, it's not due to any extensions.
Your browser is basically unusable for me in this state. If this is not fixed immediately, I'm going to switch back to Mac IE5!
Whiteboard: dupeme
Reporter | ||
Comment 2•17 years ago
|
||
This is not in the B1 release candidate, is a regression since that was cut.
Flags: blocking-firefox3?
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Updated•17 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 4•17 years ago
|
||
Turns out this isn't a duplicate of bug 403962 - the patch there doesn't fix this bug. Looking at tabbox blame, the patch for bug 156459 seems much more likely - it changed all the other tab switching shortcuts, but not Cmd+Opt+Arrow.
Assignee | ||
Updated•17 years ago
|
Summary: next/previous tab shortcuts are broken → Cmd+Opt+Arrow next/previous tab shortcut is broken
Assignee | ||
Updated•17 years ago
|
Status: REOPENED → NEW
Component: Keyboard Navigation → XUL Widgets
Flags: blocking-firefox3?
Product: Firefox → Toolkit
QA Contact: keyboard.navigation → xul.widgets
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
Target Milestone: --- → mozilla1.9 M10
Assignee | ||
Comment 5•17 years ago
|
||
This fixes it for me.
Assignee | ||
Updated•17 years ago
|
Priority: -- → P1
Comment 6•17 years ago
|
||
Comment on attachment 289433 [details] [diff] [review]
patch
r=mano
Attachment #289433 -
Flags: review?(mano) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #289433 -
Flags: approval1.9?
Comment 7•17 years ago
|
||
(In reply to comment #4)
> Looking at tabbox blame, the patch for bug 156459 seems much more
I confirm this seems to be caused by my (port) patch there.
> likely - it changed all the other tab switching shortcuts, but not
> Cmd+Opt+Arrow.
This bug must have existed in SeaMonkey before, as I synchronized the two files, nothing more.
I didn't know. Sorry.
Updated•17 years ago
|
Attachment #289433 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 8•17 years ago
|
||
Indeed, it does look like the xpfe tabbbox.xml has this bug.
Assignee | ||
Comment 9•17 years ago
|
||
mozilla/toolkit/content/widgets/tabbox.xml 1.52
Status: ASSIGNED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Comment 10•17 years ago
|
||
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007121008 Minefield/3.0b2pre.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•13 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•