404184 - Cmd+Opt+Arrow next/previous tab shortcut is broken

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8) Gecko/2007091211 GranParadiso/3.0a8
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8) Gecko/2007091211 GranParadiso/3.0a8

cmd+opt+{left/right arrow} no longer works in nightlies.

Reproducible: Always

Steps to Reproduce:
1. with more than 1 tab open, hit cmd+opt+arrow
Actual Results:  
nothing happens

Expected Results:  
next or previous tab is selected

Comment 1

[Dietrich Ayala (:dietrich)]

Note: I tried this with a new profile, it's not due to any extensions.

Your browser is basically unusable for me in this state. If this is not fixed immediately, I'm going to switch back to Mac IE5!

Comment 2

[Dietrich Ayala (:dietrich)]

This is not in the B1 release candidate, is a regression since that was cut.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Turns out this isn't a duplicate of bug 403962 - the patch there doesn't fix this bug. Looking at tabbox blame, the patch for bug 156459 seems much more likely - it changed all the other tab switching shortcuts, but not Cmd+Opt+Arrow.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This fixes it for me.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 289433 [details] [diff] [review]
patch

r=mano

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Looking at tabbox blame, the patch for bug 156459 seems much more

I confirm this seems to be caused by my (port) patch there.

> likely - it changed all the other tab switching shortcuts, but not
> Cmd+Opt+Arrow.

This bug must have existed in SeaMonkey before, as I synchronized the two files, nothing more.
I didn't know. Sorry.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Indeed, it does look like the xpfe tabbbox.xml has this bug.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/tabbox.xml 	1.52

Comment 10

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007121008 Minefield/3.0b2pre.