404216 - Removing the location bar from the toolbar leads to chaos

Status: VERIFIED DUPLICATE of bug 403854

(Firefox :: Toolbars and Customization, defect)

Description

[(no longer active)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111705 Minefield/3.0b2pre

Steps to reproduce:

1. Open the browser, and navigate to a few pages in a few tabs and make sure the bookmarks toolbar is visible (needed to demonstrate the lack of session restore functionality in Step 6).
2. Right click on the toolbar, click Customize.
3. Drag the location bar off the toolbar to remove it.
4. Click Done.

The menu bar becomes disabled, and when you right click on the toolbar to put back the location bar to where it was using the customization dialog, the Customize menu item is disabled as well!  So, effectively the user is "trapped" in this situation.

5. Close the browser window, choose Save and Quit to save your current tabs.
6. Restart the browser.

You would expect your tabs to be restored, but that is not the case!  A blank window opens (about:blank), your bookmarks toolbar appears empty, but the menu bars and the Customize option in the context menu are not disabled this time.

7. Right click on the toolbar, click Customize.
8. Drag the location bar to somewhere on the toolbar.
9. Click Done.

Again, like in step 4 above, the menu bar and the Customize menu become disabled.  This time, the location bar is non-functional.  Typing www.google.com in it and pressing Enter does not result in anything.  Pressing the Go button is futile as well.  The site's icon, the drop-down indicator and the star button don't work as well.

10. Close the browser window.

You are not prompted to save the current session or not.

11. Restart the browser.

The browser opens, this time everything is fine.  Your session from step 5 is not restored, so effectively the browser has lost the data about the open tabs in that step.

Reproducible: Always, both using a clean profile and my current testing profile.

I think we should either not allow the location bar to be removed from the toolbar, or be able to handle it gracefully.

The same tests work flawlessly in Firefox 2.0.0.9.

Comment 1

[Behnam Esfahbod [:zwnj]]

(In reply to comment #0)
> Steps to reproduce:
> 
> 1. Open the browser, and navigate to a few pages in a few tabs and make sure
> the bookmarks toolbar is visible (needed to demonstrate the lack of session
> restore functionality in Step 6).
> 2. Right click on the toolbar, click Customize.
> 3. Drag the location bar off the toolbar to remove it.
> 4. Click Done.
> 
> The menu bar becomes disabled, and when you right click on the toolbar to put
> back the location bar to where it was using the customization dialog, the
> Customize menu item is disabled as well!

If it helps, I cannot reproduce it on 3.0b1.

Comment 2

[(no longer active)]

(In reply to comment #1)
> If it helps, I cannot reproduce it on 3.0b1.

Did you try the latest nightly?  IINM some of the toolbar code has been changed from 3.0b1...

Comment 3

[Behnam Esfahbod [:zwnj]]

(In reply to comment #2)
> IINM some of the toolbar code has been changed from 3.0b1...

I know, that's why I mentioned the version, to help find where the problem is.

Comment 4

[Elmar Ludwig]

This is a know regression from bug 400327, see bug 403854.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified dup