404236 - Exception... "Index or size is negative or greater than the allowed amount" code: "1" nsresult: "0x80530001 (NS_ERROR_DOM_INDEX_SIZE_ERR)" location: "chrome://navigator/content/urlbarBindings.xml Line: 0" auto-opening the sidebar

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

No bug.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007111802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

1. Start Browser.
2. Press F9, to open the sidebar.
2r. Get 5 times the following error
[
Error: this.docShell is null
Source File: chrome://global/content/bindings/browser.xml
Line: 0
]

***

This is major because it breaks searching from the Location bar:
the sidebar opens but empty *and* the (Google result) web page does not load;
have to click on the Location bar and press Enter to resubmit the query (as a workaround) :-/

Comment 1

[Serge Gautherie (:sgautherie)]

*(OS) Windows 2000 -> All, per bug 409780 comment 15.

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011002 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

That's 8 times, now.

Comment 3

[Serge Gautherie (:sgautherie)]

> That's 8 times, now.

I guess these are all the |onget=""| property attributes in the file.

The common code/cause should be
<http://mxr.mozilla.org/seamonkey/source/toolkit/content/widgets/browser.xml>
[
 252       <field name="_docShell">null</field>
 253 
 254       <property name="docShell"
 255                 onget="return this._docShell || (this._docShell = this.boxObject.QueryInterface(Components.interfaces.nsIContainerBoxObject).docShell);"
 256                 readonly="true"/>
]
The assignment code (on the right) is the one which used to be in /xpfe.


I thought this could be bug 406697, but it does not seem so:

*fix 1:
No effect,
as expected from initial report build date (which was before the fix for bug 385224).

*fix 2: 
(Not tested, as fix 1 has no effect on the current bug.)

*fix 3: 
No effect,
although |this._docShell| is not null when |this._docShell = null;| is executed.
NB: What surprised me is that |onPageHide()| is executed [except the 1st time] immediately before |onPageShow()| when the sidebar (panel) is being _shown_,
rather than when the sidebar (panel) is being _hidden_ !
I guess the sidebar itself is hidden, but its panel is still considered shown,
until "rebuilt" when the sidebar is shown again...
The errors show up (after |onPageHide()| and) _before_ |onPageShow()|.

Comment 4

[[e-mail]]

What's going on here is that RevealSearchPanel() is causing the URLbar to lose focus, which closes its popup, which clears the selection, which makes the override value getter throw the exception.

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Confirming that (other) exception with my "search Google from URLbar" use case.
This exception appears after the 8 errors.

[
Error: uncaught exception: [Exception... "Index or size is negative or greater than the allowed amount"  code: "1" nsresult: "0x80530001 (NS_ERROR_DOM_INDEX_SIZE_ERR)"  location: "chrome://navigator/content/urlbarBindings.xml Line: 0"]
]

Comment 6

[Andrew Schultz]

Attachment: get the value before calling RevealSearchPanel [landed]

this seems hackish, but seems like the cleanest possibility

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 296677 [details] [diff] [review]
get the value before calling RevealSearchPanel [landed]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Confirming that this fixes the <urlbarBindings.xml> exception :-)
But not the <browser.xml> errors...

Comment 8

[[e-mail]]

Comment on attachment 296677 [details] [diff] [review]
get the value before calling RevealSearchPanel [landed]

I considered tweaking RevealSearchPanel but I agree this is cleaner.

Comment 9

[Andrew Schultz]

Comment on attachment 296677 [details] [diff] [review]
get the value before calling RevealSearchPanel [landed]

landed... I don't really understand the docShell errors.

Comment 10

[[e-mail]]

I don't think they were ever relevant.

Comment 11

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011303 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed.

Comment 12

[Serge Gautherie (:sgautherie)]

I agree that the error(s) and the exception are unrelated to each other.
Thanks for fixing the major part of this bug, which was the exception.

I filed bug 412171 about the (remaining) error.