404247 - Switch WebFeatures to CHPermissionManager

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Stuart Morgan]

Attachment: fix

Since I haven't had any luck figuring out how to solve bug 383934, but I'd really like to get my pref pane cleanup in before it rots any further, this just uses -undefined dynamic_lookup instead. There's theoretically a risk that we could accidentally ship without an implementation of some symbol, but in practice it's highly unlikely since essentially everything is compiled into Camino (and the pref panes are limited enough that it would be hard not to catch it in testing).

This also removes the now-unused profilePath method, which means it no longer needs to link directly against core for anything.

Comment 1

[Stuart Morgan]

Comment on attachment 289224 [details] [diff] [review]
fix

To mento, per IRC. Just ignore the now-obsolete project stuff.

Comment 2

[Mark Mentovai]

Comment on attachment 289224 [details] [diff] [review]
fix

When you do the project file for this, remember to get rid of libxpcom_core.dylib from the privacy pane if it's no longer needed, and to reset the header search path for this pane to something less Geckoy (../dist/include at a minimum).

Comment 3

[Stuart Morgan]

Comment on attachment 289224 [details] [diff] [review]
fix

I'll fix mento's comments on checkin.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 289224 [details] [diff] [review]
fix

rs=pink

Comment 5

[Stuart Morgan]

Attachment: v2

Here's the updated version, which I'll check in when I have a chance. It strips out the unneeded header/library paths, the library linking, the precompiled header (which pulls in Gecko headers), and fixes a leak + crash that I had missed just for good measure.

Comment 6

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.