Open
Bug 404259
Opened 19 years ago
Updated 4 years ago
Make "Today" button look toggled when today is selected in the views
Categories
(Calendar :: Calendar Frontend, enhancement)
Calendar
Calendar Frontend
Tracking
(Not tracked)
NEW
People
(Reporter: noname5927, Unassigned)
Details
(Keywords: good-first-bug)
Attachments
(5 files)
|
3.62 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
|
11.91 KB,
image/png
|
Details | |
|
7.84 KB,
image/png
|
clarkbw
:
ui-review+
andreasn
:
feedback+
|
Details |
|
4.47 KB,
image/png
|
Details | |
|
17.63 KB,
image/png
|
Details |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071025 Firefox/2.0.0.9
Build Identifier:
"Today" button on toolbar could become selected (sunken) after click and remain selected while today is shown in Day view or is selected in Week/Month view.
I think this will ease up navigation, and also look nicer. This idea was implemented in the now discontinued Ecco Pro
Reproducible: Always
Comment 1•18 years ago
|
||
Cc'ing Christian for an UI expert opinion.
Comment 2•17 years ago
|
||
Should be quite easy to fix, also cc'ing bryan for an opinion.
Status: UNCONFIRMED → NEW
Component: General → Calendar Views
Ever confirmed: true
QA Contact: general → views
Summary: Make "Today" button on toolbar toggleable → Make "Today" button look toggled when today is selected in the views
Whiteboard: [good first bug]
Comment 3•17 years ago
|
||
yeah this sounds good
But it's been 20 months since my post... should these messages be reviewed more often?
In this patch I've added a method in calendar-base-view.xml that changes the today button state. The method is called from goToDay() methods for each view.
As far as I can see, every time a different view has to be generated, the code always executes the goToDay() method, therefore I put the call in that point. Hope I haven't missed something.
For the look of the button, at the beginnig I had used the "checked" state but IMO the "open" state is better (for the background color different from that one of the navigation bar). In the "checked" state, the label "today" is misplaced to the right, like every button in checked state, but the look seems ... too flat, it doesn't seem a checked button apart from the misplacement of the label. Moreover the button is smaller and moves the right arrow button some pixels to the left, so it would need some css properties adjustment.
I've attached a screenshot with both "open" and "checked" state of the button. Does it need an UI review?
Updated•16 years ago
|
Attachment #418026 -
Attachment description: patch → [short] patch
Comment 7•16 years ago
|
||
Comment on attachment 418026 [details] [diff] [review]
[short] patch
>+ <method name="updateTodayButton">
>+ <body><![CDATA[
>+ let todaybutton = document.getElementById("today-view-button");
>+ if () {
>+ todaybutton.setAttribute("open", "true");
>+ } else {
>+ todaybutton.removeAttribute("open");
>+ }
let curDate = cal.now();
setElementValue("today-view-button",
(this.mStartDate.compare(curDate) <= 0 &&
this.mEndDate.compare(curDate) >= 0) && "true",
"open");
Otherwise this looks fine. I'll fix this before push.
Attachment #418026 -
Flags: review?(philipp) → review+
Comment 8•16 years ago
|
||
Not sure I like the looks of this on linux. It kind of makes the button look like you can uncheck it. Bryan, do you have a different suggestion maybe?
Attachment #427459 -
Flags: ui-review?(clarkbw)
Updated•16 years ago
|
Attachment #427459 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 9•16 years ago
|
||
Comment on attachment 427459 [details]
Linux Screenshot
We could try to style it better than it appears now though I'm not sure about making it look different than other buttons of that type. But I think the effect is correct in general.
Comment 10•16 years ago
|
||
Bryan, I'm fine with still making it look like a button, do you have a suggestion how it could be better styled?
Updated•16 years ago
|
Attachment #427459 -
Flags: feedback?(clarkbw)
Comment 11•16 years ago
|
||
Comment on attachment 427459 [details]
Linux Screenshot
The feedback request was rather meant for comment 10.
Comment 12•16 years ago
|
||
Comment on attachment 427459 [details]
Linux Screenshot
handing this over to andreas, see comment 10
Attachment #427459 -
Flags: feedback?(clarkbw) → feedback?(nisses.mail)
Comment 13•16 years ago
|
||
Having it look pressed is ok behavior consistency-wise, as this kind of navigation UI can be seen in Nautilus (GNOME default file manager) and the GTK+ filechooser among others.
There is always the risk of confusing it with a toggle button (buttons are always funny), but the GTK+ toolkit don't make any visual difference between those, so we're not a worse than anyone else.
Updated•16 years ago
|
Attachment #427459 -
Flags: feedback?(nisses.mail) → feedback+
Comment 14•16 years ago
|
||
Decathlon, is this patch ready for checkin (with the nit fixed)?
Comment 15•16 years ago
|
||
(In reply to comment #14)
> Decathlon, is this patch ready for checkin (with the nit fixed)?
AFAICS, there is a feedback+ (comment 13) about the screenshot attachment 427459 [details] which is from the patch (comment 8 and comment 9) but, maybe, the question in comment 10 has not had an explicit answer, so I think Philipp should answer to your question.
Let me know if I have to change something.
Comment 16•15 years ago
|
||
Andreas, could you tell us your opinion on comment 10? From comment 13 I understand you're ok with making it look like a standard toggle button, but do you think it could be styled a bit differently?
Comment 17•15 years ago
|
||
In the past I had tried to give to the button some styles just to see a different look. In this screenshot there is also a comparison with Google calendar's buttons.
Comment 18•15 years ago
|
||
Another open UI decision! How can this bug be moved forward?
Comment 19•14 years ago
|
||
This has my vote - anything that makes the Today button stand out is a plus for me. At the moment, without an exension tweaking it (and even with) the current day is almost impossible to distinguish from the rest. Considering this is the most prominent piece of information in the calendar for typical use, this *should* stand out very easily.
Updated•6 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug]
Updated•6 years ago
|
Assignee: bv1578 → nobody
Status: ASSIGNED → NEW
Updated•4 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•