If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[FIX]layout can pass widgets a layout width of "1<<30"

RESOLVED FIXED

Status

()

Core
Layout
P4
critical
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Josh Aas, Assigned: bz)

Tracking

unspecified
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
In bug 398336 we discovered that layout can pass widgets a layout width of "1<<30". This almost certainly shouldn't be happening.

"Loading the testcase from Bug 398158 (https://bugzilla.mozilla.org/attachment.cgi?id=283018)(and clicking on this bar) freeze Trunk Builds and the entire mac system."

I've heard that the freeze will only happen the first time the  bad code runs on a boot, so if you reproduce it once you'll have to reboot to get it again. Presumably the layout bug still happens but Mac OS X just doesn't freeze up more than once.
Flags: blocking1.9?
(Reporter)

Updated

10 years ago
Blocks: 398336

Updated

10 years ago
No longer blocks: 398336

Updated

10 years ago
Depends on: 398336
(Reporter)

Comment 1

10 years ago
As noted in the other bug, this is a regression from Eli's Gecko units patch.

"I've traced it to the Gecko units patch in bug 177805, landed back in February; previous code works, apply patch, rebuild, now it fails." - Stan Shebs
I can't load the bug in comment 0....

This is likely the same as bug 363858, if https://bugzilla.mozilla.org/attachment.cgi?id=283018 is the right testcase.
(Reporter)

Comment 3

10 years ago
Sorry, bug 398157.

Attachment:
https://bugzilla.mozilla.org/attachment.cgi?id=283018
We probably should have some bulletproofing in widget code to protect against creating super-large widgets.
Flags: blocking1.9? → blocking1.9+
Priority: -- → P4
(Reporter)

Comment 5

10 years ago
See bug 398336 comment #15, that bug is about bulletproofing in widget code now.
Patch in bug 363858 will fix this.
Depends on: 363858
Summary: layout can pass widgets a layout width of "1<<30" → [FIX]layout can pass widgets a layout width of "1<<30"
Fixed by checkin for bug 363858.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.