404315 - [FIX]Improve signature of nsICSSParser::Parse

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

As the summary says.  Also drops more stuff when done parsing, and even more if we recycle the parser, so we don't keep things alive for a long time.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 289293 [details] [diff] [review]
Like so

r+sr=dbaron.  Sorry for the delay here.

I wonder if we should move even further to a model where the sheet is input to nsICSSParser::Parse and some of the other methods (instead of a pile of URIs and a principal), and the parser only holds onto it for the duration of those methods.

Comment 2

[Boris Zbarsky [:bzbarsky]]

That might not be a bad idea, esp. once we have the mmgc stuff and don't need to refcount all those things as we get them off the sheet.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 289293 [details] [diff] [review]
Like so

This is a simple change to make it harder for users of this API to shoot themselves in the foot.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 289293 [details] [diff] [review]
Like so

a=beltzner for 1.9

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.