Add Exception Dialogs looks broken

RESOLVED FIXED

Status

Core Graveyard
Security: UI
RESOLVED FIXED
10 years ago
a year ago

People

(Reporter: kaie, Assigned: johnath)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
I'm attaching a screenshot. This is what the add exception dialog looks like on linux trunk.

The bold heading has weird indenting.

The boxes around the sections are gone.
(Reporter)

Comment 1

10 years ago
Created attachment 289414 [details]
screen shot
(Assignee)

Comment 2

10 years ago
Created attachment 289510 [details] [diff] [review]
Remove whitespace around entity

Sigh...

The text is styled as moz-pre-wrap, but the XUL assumes that it's okay to leave whitespace around the entity.  This wasn't spotted when the code first landed because the CSS rule was broken.  When the fix to the CSS landed, it "regressed" this, but that just never should have been there.  My bad.  :(
Assignee: kengert → johnath
Status: NEW → ASSIGNED
Attachment #289510 - Flags: review?(kengert)
(Reporter)

Comment 3

10 years ago
Comment on attachment 289510 [details] [diff] [review]
Remove whitespace around entity

Thanks for the fix, r=kengert

Nit: Would it make sense to avoid very long lines by moving the ">" to the next line? Like this:

  <description id="warningSupplemental"
               style="font-weight: bold; white-space: -moz-pre-wrap;"
  >&exceptionMgr.supplementalWarning;</description>

(or similar).

Would it make sense to add a <!--comment--> explaining that whitespace must be avoided between the tags?
Attachment #289510 - Flags: review?(kengert) → review+
(Assignee)

Comment 4

10 years ago
Created attachment 289514 [details] [diff] [review]
Nits addressed

Requesting approval.  This is absolutely not a blocker, but it also looks stupid (see attachment 289414 [details]) and broken in its current form.  There is zero semantic change here, just whitespace around a DTD entity.  Under normal circumstances I don't think I'd even request a=, but I know we are clamping down.
Attachment #289510 - Attachment is obsolete: true
Attachment #289514 - Flags: approval1.9?

Updated

10 years ago
Attachment #289514 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 5

10 years ago
Checking in security/manager/pki/resources/content/exceptionDialog.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v  <--  exceptionDialog.xul
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.