404495 - Native GTK style for menu checkboxes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111904 Minefield/3.0b2pre

The checkboxes in dialog windows (preferences etc) have a nice GTK look now, even checkboxes in webpages look GTK-native in FF3. The only place were the checkboxes look different is the menu. Would be nice if FF3 would pick up the native look here, too.

Reproducible: Always

Comment 1

[Michael Monreal [:micmon]]

Attachment: Comparison FF3 <-> native

Comment 2

[Michael Monreal [:micmon]]

Btw, FF3 is already using GTK native radio buttons in menus.

Comment 3

[Michael Ventnor]

Attachment: Patch

This seems to do it for me by removing an evil assumption. I'm not sure how this would look under GNOME 2.20 as this computer uses Ubuntu Feisty instead of Gutsy. Any plans to upgrade this thing, Roc?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 290156 [details] [diff] [review]
Patch

Just verify that that style was available in old versions of GTK.

Comment 5

[Michael Ventnor]

Comment on attachment 290156 [details] [diff] [review]
Patch

Its been there since 2.8, the oldest documentation I could find. So I think we're safe.

Comment 6

[Michael Monreal [:micmon]]

I remember someone saying on our little IRC meeting that the lower dependency for GTK was upped to 2.10 for FF3.

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> I remember someone saying on our little IRC meeting that the lower dependency
> for GTK was upped to 2.10 for FF3.

See http://wiki.mozilla.org/Linux/Runtime_Requirements for the complete list.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 290156 [details] [diff] [review]
Patch

a=beltzner for drivers

Comment 9

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.43; previous revision: 1.42
done