404501 - "Get me out of here", "Add exception" buttons don't have access keys

Status: RESOLVED FIXED

(Firefox :: Security, defect, P3)

Description

[Matthew Wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1

After an SSL error, selecting "Add an exception" brings up an area with "Get me out of here!" and "Add exception" buttons. These buttons do not have keyboard shortcuts.

Reproducible: Always

Steps to Reproduce:
Select "Add exception".
Actual Results:  
There are no specific keyboard shortcuts for the buttons. (Tabbing to the buttons works.)

Expected Results:  
Keyboard short cuts like Alt-G, Alt-A (or similar) should be available.

Comment 1

[Gervase Markham [:gerv]]

<sigh> This would have been easy to do any time over the past few months, but now we have an l10n freeze. This is an a11y problem.

The tinderbox page doesn't link to nomination rules; taking a wild stab in the dark and trying blocking‑firefox3 (as wanted-firefox3 doesn't seem to be available to me).

Gerv

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

It's in the tab order, so it doesn't block the final release.

Comment 3

[Manuel Bucher [:manuel]]

Raising as potentially good to be addressed in the certificate error page redesign, but shouldn't block enabling the design. Could also moved back to backlog (potentially blocking Bug 1442203 instead?). I think would be a good time to get addressed anyhow, especially if it doesn't require much additional effort.

I reached out on #accessibility and got the following assessment:

It's certainly a nice to have, but it absolutely isn't blocking given that there are only a couple of buttons and they should be reachable with the tab key. I think the s4 rating of that bug is appropriate. That said, if you're using HTML, it should also be fairly straightforward to implement using the accesskey attribute.

Comment 4

[Jack Brown]

Attachment: Bug 404501 - Add access keys to error pages. - r?niklas,jaws

| Button | Access Key | Windows/Linux | macOS |
| Go Back | G | Alt+G | Control+G |
| Try Again | T | Alt+T | Control+T |
| Proceed to Site (Risky) | P | Alt+P | Control+P |

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d28f5a2de109
https://hg.mozilla.org/integration/autoland/rev/94fa1015592d
Add access keys to error pages. - r=niklas,fluent-reviewers,bolsson,flod

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/94fa1015592d