404682 - Gmail compose "quote" function broken

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

If you try to compose a message in gmail using Minefield on either Mac or Windows, you can't use the "quote" feature of the rich text editor. It works in FF2 (on Windows at least).

Steps to reproduce:
1. Load gmail in Minefield/FF3.
2. Click "Compose Mail" link.
3. Enter some text in the message body.
4. Select the text entered in (3).
5. Click the quote button on the rich text editor tool bar ('').
6. Observe that the text isn't quoted.

Expected result: the text should have a light blue/gray vertical bar prepended to it, and be indented slightly.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

This one's a bit messy, gmail's quoting works on the nightly build on 2007-06-27 11:00:00, but the next day the iframe/design mode breaks - the caret does show up in the iframe, and you can't enter any text. The iframe stays uneditable until the nightly build at 2007-08-31 05:00:00, but in that build the bug occurs.

So the regression range is 2007-06-27 11:00:00 -> 2007-08-31 05:00:00, though I think it's most likely whatever caused the bustage in 2007-06-27 -> 2007-06-28 caused this regression.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yikes, the regression range for 2007-06-27 11:00 and 2007-06-28 05:00, http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-06-27+11%3A00%3A00&maxdate=2007-06-28+05%3A00%3A00&cvsroot=%2Fcvsroot
contains a large checkin of the editor stuff for 237964. I guess that's where the problem is...

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

This now kinda works. If you click on the quote button now, first the cursor moves up half a line (so it's drawn vertically offset upwards, similar to bug 389321) and then pressing the quote button again makes the quote appear as it should. 

This started partially working again between nightlies 2007-11-28 and 2007-11-29.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I also note that the following assertions/warnings are firing, but only on the first time I try to quote. If I enter text before quoting, or if I quote and then unquote, the errors don't occur. Maybe there's some kind of initialization that needs to happen?



WARNING: refusing to set request header: file c:/work/src/head/mozilla/content/base/src/nsXMLHttpRequest.cpp, line 2173
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80530001: file c:/work/src/head/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 213
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80530001: file c:/work/src/head/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 779
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "invalid 'in' operand a" {file: "http://mail.google.com/mail/?ui=2&view=jsm&name=bjs&ids=1k1f1is80ru5b%2C1on5mltqjctek&l=0" line: 372}]' when calling method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file c:/work/src/head/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 251
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file c:/work/src/head/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 1660

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

This now works again -> WFM.